From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Date: Fri, 26 Mar 2010 05:15:12 +0800 Subject: [Ocfs2-devel] [PATCH] ocfs2: one more warning fix in ocfs2_file_aio_write(), v2 Message-ID: <4BABD260.4070600@suse.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com This patch fixes another compiling warning in ocfs2_file_aio_write() like this, fs/ocfs2/file.c: In function ?ocfs2_file_aio_write?: fs/ocfs2/file.c:2026: warning: suggest parentheses around ?&&? within ?||? As Joel suggested, '!ret' is unary, this version removes the wrap from '!ret'. Signed-off-by: Coly Li Cc: Joel Becker --- fs/ocfs2/file.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 17947dc..c4638fd 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -2021,8 +2021,8 @@ out_dio: if (ret < 0) written = ret; - if (!ret && (old_size != i_size_read(inode) || - old_clusters != OCFS2_I(inode)->ip_clusters || + if (!ret && ((old_size != i_size_read(inode)) || + (old_clusters != OCFS2_I(inode)->ip_clusters) || has_refcount)) { ret = jbd2_journal_force_commit(osb->journal->j_journal); if (ret < 0) -- Coly Li SuSE Labs