All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] support for "elif" in grub script
Date: Fri, 26 Mar 2010 15:13:58 +0100	[thread overview]
Message-ID: <4BACC126.9020700@gmail.com> (raw)
In-Reply-To: <affa79921003160545k33c4403dg1845774c154bf453@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

Deepak Vankadaru wrote:
> Hi
>
> This is my patch submission after a while. I have submitted fixes for
> grub_printf in the past, which is still pending on merge conflicts.
>
grub_printf enhancements were considered unnecessary. grub_printf is
size-constrained and additional functionality is added to it only if
there is a good reason for it.
> Attached patch contains changes on top of "for-loops" branch to
> support "elif" construct in grub script. Please review and let me know
> if anything else needs to be done to get this comitted.
Looks good except absence of ChangeLog entry and that it doesn't apply
to current trunk. Can you fix those?
>
> Thanks
> Deepak
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>   


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]

      reply	other threads:[~2010-03-26 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 12:45 [PATCH] support for "elif" in grub script Deepak Vankadaru
2010-03-26 14:13 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BACC126.9020700@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.