Re: Broken build

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2500 bytes --]

Bruce Dubbs wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> Carles Pina i Estany wrote:
>>> Hi,
>>>
>>> On Mar/17/2010, Bruce Dubbs wrote:
>>>  
>>>> With the addition of the internationalization code, building GRUB in
>>>> a separate directory fails.
>>>>     
>>> I'll take a look into it "soon" (next days or next week)
>>>
>>> Probably it's an easy thing, if someone checks it before please report
>>> :-)
>>>   
>>         cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>> -f $< --keyword=_ --keyword=N_
>> to
>>         cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
>> -f po/POTFILES --keyword=_ --keyword=N_
>> Feel free to test & commit
>
> I don't think so.  
Well you have a funny way of disagreeing arriving to the same result as
I told: replace
        cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f $< --keyword=_ --keyword=N_
with
        cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@
-f po/POTFILES --keyword=_ --keyword=N_
Have you tested it?

> When generated, the makefile has:
>
> $(srcdir)/po/$(PACKAGE).pot: po/POTFILES po/POTFILES-shell
>    cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ -f
> $< --keyword=_ --keyword=N_
>
> which when instantiated by make is:
>
> ../po/grub.pot: po/POTFILES po/POTFILES-shell
>   cd .. && /usr/bin/xgettext -ctranslate --from-code=utf-8 \
>            -o ../po/grub.pot -f po/POTFILES --keyword=_ --keyword=N_
>
> /usr/bin/xgettext: cannot create output file "../po/grub.pot": No such
> file or directory
>
> If I change this to:
>
> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
>   mkdir -p po
>   $(XGETTEXT) -ctranslate --from-code=utf-8 -o $@ \
>   -f $< --keyword=_ --keyword=N
>
> I get the error:
>
>   /usr/bin/xgettext: error while opening "commands/acpi.c" for
> reading: No such file or directory
>
> We need something like:
>
> po/grub.pot: $(srcdir)/po/POTFILES $(srcdir)/po/POTFILES-shell
>   mkdir -p po
>   DIR=$PWD
>   cd $(srcdir) && $(XGETTEXT) -ctranslate --from-code=utf-8 \
>     -o $(DIR)/$@ -f po/POTFILES --keyword=_ --keyword=N
>
> The use of $< is wrong here because of the cd command.
>
>
>   -- Bruce
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]