All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: linux-sctp@vger.kernel.org
Subject: Re: connect() hangs after binding to three IP addresses and auth_enable
Date: Fri, 26 Mar 2010 14:36:05 +0000	[thread overview]
Message-ID: <4BACC655.1050607@hp.com> (raw)
In-Reply-To: <001701cacc68$d6bb1390$84313ab0$@com>

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi George

George Cheimonidis wrote:
> Hi Vlad!
> 
> I am sending this email, after the discussion that we had in the forum
> thread
> https://sourceforge.net/projects/lksctp/forums/forum/83479/topic/3615562.
> This was related to the problem that I faced when using connect() after
> binding to three IP addresses  (two IPv4 and one IPv6). The problem seemed
> to occur when auth_enable is set. 
> I am willing to rebuild the SCTP module with the patches that you mentioned.
> Please provide me with some instructions on how to apply these patches, if
> possible.
> 
> Best regards,
> George 
> 


Here is a debug patch that should apply against either 2.6.31 or 2.6.33.
To apply it, you'll need the Ubuntu sources or sources from kernel.org

To apply them, just use
	$ patch -p1 < patchfile

Then rebuild the kernel or just the sctp module if you don't want to wait too
long.  To build the module you do
	$ make net/sctp/sctp.ko

Thanks for doing this.
-vlad

[-- Attachment #2: patchfile --]
[-- Type: text/plain, Size: 816 bytes --]

diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 9e73291..22a30ac 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -228,6 +228,8 @@ struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc,
 		chunksize += sizeof(aiparam);
 
 	chunksize += vparam_len;
+	
+	printk("DEBUG: INIT size prior to Auth %zd\n", chunksize);
 
 	/* Account for AUTH related parameters */
 	if (sctp_auth_enable) {
@@ -256,6 +258,9 @@ struct sctp_chunk *sctp_make_init(const struct sctp_association *asoc,
 	if (num_ext)
 		chunksize += sizeof(sctp_supported_ext_param_t) + num_ext;
 
+	printk("DEBUG: INIT size after AUTH and extensions(%d) %zd",
+			num_ext, chunksize);
+
 	/* RFC 2960 3.3.2 Initiation (INIT) (1)
 	 *
 	 * Note 3: An INIT chunk MUST NOT contain more than one Host

  reply	other threads:[~2010-03-26 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25 22:16 connect() hangs after binding to three IP addresses and auth_enable is set George Cheimonidis
2010-03-26 14:36 ` Vlad Yasevich [this message]
2010-03-27 12:51 ` connect() hangs after binding to three IP addresses and auth_enable George Cheimonidis
2010-03-29  4:11 ` Wei Yongjun
2010-03-29 13:02 ` Vlad Yasevich
2010-03-30  1:41 ` Wei Yongjun
2010-03-30 15:06 ` George Cheimonidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BACC655.1050607@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.