From: Richard Henderson <rth@twiddle.net>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: martin.mohring@opensuse.org, Riku Voipio <riku.voipio@nokia.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] fix 0 sized write syscall
Date: Fri, 26 Mar 2010 09:07:32 -0700 [thread overview]
Message-ID: <4BACDBC4.2060501@twiddle.net> (raw)
In-Reply-To: <52e932ccb17304f60def454d2154726c972bacb6.1269616764.git.riku.voipio@nokia.com>
On 03/26/2010 08:25 AM, Riku Voipio wrote:
> + if (len == 0) {
> + return 0;
> + }
This part is ok.
>
> - if (start + len - 1 < start) {
> + if (start + len < start) {
This part re-introduces the bug I fixed.
start = 0xffffff00
len = 256
should succeed, and it won't reverting the (len-1) change.
r~
prev parent reply other threads:[~2010-03-26 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 15:25 [Qemu-devel] [PATCH 0/4] linux-user patches for upstream Riku Voipio
2010-03-26 15:25 ` [Qemu-devel] [PATCH 1/4] linux-user: add pselect syscall Riku Voipio
2010-03-26 22:15 ` Aurelien Jarno
2010-03-26 23:05 ` Paul Brook
2010-03-28 18:49 ` Jamie Lokier
2010-03-26 15:25 ` [Qemu-devel] [PATCH 2/4] linux-user: Add the syscall id for pselect6 on ARM Riku Voipio
2010-03-26 22:13 ` Aurelien Jarno
2010-03-26 15:25 ` [Qemu-devel] [PATCH 3/4] Add inotify_init1 syscall support Riku Voipio
2010-03-26 22:14 ` Aurelien Jarno
2010-03-26 15:25 ` [Qemu-devel] [PATCH 4/4] fix 0 sized write syscall Riku Voipio
2010-03-26 16:07 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BACDBC4.2060501@twiddle.net \
--to=rth@twiddle.net \
--cc=martin.mohring@opensuse.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=riku.voipio@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.