From: Michael Tokarev <mjt@tls.msk.ru>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages
Date: Sat, 27 Mar 2010 16:35:37 +0300 [thread overview]
Message-ID: <4BAE09A9.8020505@msgid.tls.msk.ru> (raw)
In-Reply-To: <20100327123350.GA19617@volta.aurel32.net>
Aurelien Jarno wrote:
> On Tue, Mar 16, 2010 at 11:01:46AM +0300, Michael Tokarev wrote:
>> The error message qemu gives when hugetlbfs is not
>> accessible is cryptic at best:
>>
>> mkstemp: Permission denied
>>
>> Make it a bit more specific instead:
>>
>> unable to create backing store for hugepages: Permission denied
>>
>> Thanks!
>
> It looks good, but needs a Signed-off-by: line.
Are we now requiring such S-o-b lines even for such trivial stuff?
Oh well..... Ok, here we go, with another perror() case converted
to be a bit less cryptic. Thanks!
Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/exec.c b/exec.c
index fcffb0f..90032a5 100644
--- a/exec.c
+++ b/exec.c
@@ -2438,7 +2438,7 @@ static long gethugepagesize(const char *path)
} while (ret != 0 && errno == EINTR);
if (ret != 0) {
- perror("statfs");
+ perror(path);
return 0;
}
@@ -2483,7 +2483,7 @@ static void *file_ram_alloc(ram_addr_t memory, const char *path)
fd = mkstemp(filename);
if (fd < 0) {
- perror("mkstemp");
+ perror("unable to create backing store for hugepages");
free(filename);
return NULL;
}
prev parent reply other threads:[~2010-03-27 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 8:01 [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages Michael Tokarev
2010-03-27 12:33 ` Aurelien Jarno
2010-03-27 13:35 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAE09A9.8020505@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.