All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timo Teräs" <timo.teras@iki.fi>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] flow: virtualize get and entry deletion methods
Date: Mon, 29 Mar 2010 15:03:26 +0300	[thread overview]
Message-ID: <4BB0970E.7060405@iki.fi> (raw)
In-Reply-To: <20100329115701.GA24367@gondor.apana.org.au>

Herbert Xu wrote:
> I'm not talking about the flow cache.  The current flow cache
> code doesn't even take the lock.
>
> I'm talking about the other places that you have to convert in
> order to make this into an atomic_t.

Did you check the other places?

All other places do:
  fox x policies:
    lock(x)
    pol_dead |= x->walk.dead;
    unlock(x)
  if pol_dead
    abort

or similar.

And some cases don't even bother to lock the policy currently
when reading walk.dead.

All of the code treats the walk.dead as a hint. It does not need
strong synchronization with a lock.

  reply	other threads:[~2010-03-29 12:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-25  9:24 [PATCH RFC 0/2] caching bundles instead of policies Timo Teras
2010-03-25  9:24 ` [PATCH RFC 1/2] flow: virtualize get and entry deletion methods Timo Teras
2010-03-25 19:26   ` David Miller
2010-03-26  6:17     ` Timo Teräs
2010-03-29  8:40     ` Herbert Xu
2010-03-29  9:00       ` Timo Teräs
2010-03-29  9:09         ` Herbert Xu
2010-03-29 10:07           ` Timo Teräs
2010-03-29 10:26             ` Herbert Xu
2010-03-29 10:36               ` Timo Teräs
2010-03-29 11:10                 ` Herbert Xu
2010-03-29 11:23                   ` Timo Teräs
2010-03-29 11:32                     ` Herbert Xu
2010-03-29 11:39                       ` Timo Teräs
2010-03-29 11:57                         ` Herbert Xu
2010-03-29 12:03                           ` Timo Teräs [this message]
2010-03-29 12:11                             ` Herbert Xu
2010-03-29 12:20                               ` Timo Teräs
2010-03-29 12:25                                 ` Herbert Xu
2010-03-29 12:33                                   ` Timo Teräs
2010-03-29 12:45                                     ` Herbert Xu
2010-03-25  9:24 ` [PATCH RFC 2/2] xfrm: cache bundles instead of policies for outgoing flows Timo Teras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB0970E.7060405@iki.fi \
    --to=timo.teras@iki.fi \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.