From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH #upstream 1/2] ahci: clean up board IDs
Date: Mon, 29 Mar 2010 16:20:08 -0400 [thread overview]
Message-ID: <4BB10B78.9070409@garzik.org> (raw)
In-Reply-To: <4BB00337.1030302@kernel.org>
On 03/28/2010 09:32 PM, Tejun Heo wrote:
> ahci over time has grown a number of board IDs and it's a bit of mess
> right now. Clean it up such that,
>
> * board_id_* now live in a separate enum board_ids and numbers are
> assigned automatically.
>
> * Board IDs assigned to features are separated from the ones assigned
> to specific implementations and both are ordered alphabetically.
>
> * For NV MCPs, define per-generation alias board_ids and assign
> matching aliases in the pci id table. This makes mcp_linux, 67-73
> use board_ahci_mcp65 instead of board_ahci_yesncq. Both are
> identical in content.
>
> * Kill now unused board_ahci_nopmp and board_ahci_yesncq.
>
> This patch doesn't cause any functional change but will make future
> changes to board_ids and quirks much less painful.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Cc: Peer Chen<pchen@nvidia.com>
> ---
> Updated against the new #upstream. Thanks.
>
> drivers/ata/ahci.c | 237 ++++++++++++++++++++++++++---------------------------
> 1 file changed, 117 insertions(+), 120 deletions(-)
applied
prev parent reply other threads:[~2010-03-29 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 1:32 [PATCH #upstream 1/2] ahci: clean up board IDs Tejun Heo
2010-03-29 1:33 ` [PATCH #upstream 2/2] ahci: implement AHCI_HFLAG_NO_FPDMA_AA and update NV quirks Tejun Heo
2010-03-29 20:20 ` Jeff Garzik
2010-03-30 1:28 ` [PATCH #upstream RESEND " Tejun Heo
2010-03-30 17:02 ` Jeff Garzik
2010-03-29 20:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB10B78.9070409@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.