All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Matt Turner <mattst88@gmail.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	ang@brigante.org
Subject: Re: [RFC] alpha: hack objstrip.c to make it compile.
Date: Tue, 30 Mar 2010 07:28:59 -0700	[thread overview]
Message-ID: <4BB20AAB.7000909@twiddle.net> (raw)
In-Reply-To: <1269913795-1852-1-git-send-email-mattst88@gmail.com>

On 03/29/2010 06:49 PM, Matt Turner wrote:
> I don't think this is the appropriate fix. What should I do to fix this?
> ---
>  arch/alpha/boot/tools/objstrip.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/alpha/boot/tools/objstrip.c b/arch/alpha/boot/tools/objstrip.c
> index 367d53d..54fa1ef 100644
> --- a/arch/alpha/boot/tools/objstrip.c
> +++ b/arch/alpha/boot/tools/objstrip.c
> @@ -27,6 +27,9 @@
>  #include <linux/param.h>
>  #ifdef __ELF__
>  # include <linux/elf.h>
> +# define elfhdr	elf64_hdr
> +# define elf_phdr	elf64_phdr
> +# define elf_check_arch(x) ((x)->e_machine == EM_ALPHA)
>  #endif
>  

Hum.  Is it so bad to just #define __KERNEL__ here before
that one include?  Similar games are played in tools/perf/,
and with a suitible comment I think that should be all right.


r~

  reply	other threads:[~2010-03-30 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30  1:49 [RFC] alpha: hack objstrip.c to make it compile Matt Turner
2010-03-30 14:28 ` Richard Henderson [this message]
2010-03-30 14:49   ` Matt Turner
2010-03-30 14:49     ` Matt Turner
2010-03-30 14:59     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB20AAB.7000909@twiddle.net \
    --to=rth@twiddle.net \
    --cc=ang@brigante.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.