From: Nishanth Menon <nm@ti.com>
To: "S, Venkatraman" <svenkatr@ti.com>
Cc: "Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Kadiyala, Kishore" <kishore.kadiyala@ti.com>
Subject: Re: [PATCH]omap hsmmc: fix incorrect capability reporting
Date: Tue, 30 Mar 2010 13:29:30 -0500 [thread overview]
Message-ID: <4BB2430A.80701@ti.com> (raw)
In-Reply-To: <618f0c911003301111r3781661asa444dd35042772c3@mail.gmail.com>
S, Venkatraman had written, on 03/30/2010 01:11 PM, the following:
[..]
>>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>>> index 83f0aff..dbf83a6 100644
>>> --- a/drivers/mmc/host/omap_hsmmc.c
>>> +++ b/drivers/mmc/host/omap_hsmmc.c
>>> @@ -2093,7 +2093,7 @@ static int __init omap_hsmmc_probe(struct
>>> platform_device *pdev)
>>>
>>> if (mmc_slot(host).wires >= 8)
>>> mmc->caps |= MMC_CAP_8_BIT_DATA;
>>> - else if (mmc_slot(host).wires >= 4)
>>> + if (mmc_slot(host).wires >= 4)
>>> mmc->caps |= MMC_CAP_4_BIT_DATA;
>>>
>> Since 8-bit is the max how about:
>>
>> if (mmc_slot(host).wires == 8)
>> mmc->caps |= MMC_CAP_8_BIT_DATA | MMC_CAP_4_BIT_DATA;
>> if (mmc_slot(host).wires == 4)
>> mmc->caps |= MMC_CAP_4_BIT_DATA;
>>
>> This would be little easy to read the code.
>
> Sure. Works for me.
nitpicky comment: might be better off using a
switch(mmc_slot(host).wires) statement instead of using == if that is
the intention here..
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-03-30 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 14:37 [PATCH]omap hsmmc: fix incorrect capability reporting Venkatraman S
2010-03-30 15:47 ` Madhusudhan
2010-03-30 18:11 ` Venkatraman S
2010-03-30 18:29 ` Nishanth Menon [this message]
2010-03-30 18:42 ` Venkatraman S
2010-03-31 5:20 ` kishore kadiyala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB2430A.80701@ti.com \
--to=nm@ti.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.