From: Eamon Walsh <ewalsh@tycho.nsa.gov>
To: Joshua Brindle <jbrindle@tresys.com>
Cc: SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH] Add implicit lib requirements to LDLIBS
Date: Tue, 30 Mar 2010 19:34:57 -0400 [thread overview]
Message-ID: <4BB28AA1.9060508@tycho.nsa.gov> (raw)
In-Reply-To: <1269983319-10453-1-git-send-email-jbrindle@tresys.com>
On 03/30/2010 05:08 PM, Joshua Brindle wrote:
> Fedora 13 changed their linker behavior to not link indirect libraries.
> See information at: http://fedoraproject.org/wiki/UnderstandingDSOLinkChange
>
I skimmed over semodule.c and setsebool.c and I didn't see any
references to bzip2 or ustr symbols. My reading of the article suggests
the below fix should only be needed if that were the case. Most likely
I missed them?
Without this patch, do you get the linker error that says to add them?
> Resent, it doesn't look like it made it to the list the first time (and the subject had a typo)
>
> Signed-off-by: Joshua Brindle <jbrindle@tresys.com>
> ---
> policycoreutils/semodule/Makefile | 2 +-
> policycoreutils/setsebool/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/policycoreutils/semodule/Makefile b/policycoreutils/semodule/Makefile
> index c96a286..a0bbc21 100644
> --- a/policycoreutils/semodule/Makefile
> +++ b/policycoreutils/semodule/Makefile
> @@ -7,7 +7,7 @@ LIBDIR ?= ${PREFIX}/lib
>
> CFLAGS ?= -Werror -Wall -W
> override CFLAGS += -I$(INCLUDEDIR)
> -LDLIBS = -lsepol -lselinux -lsemanage -L$(LIBDIR)
> +LDLIBS = -lsepol -lselinux -lsemanage -lbz2 -lustr -L$(LIBDIR)
> SEMODULE_OBJS = semodule.o
>
> all: semodule
> diff --git a/policycoreutils/setsebool/Makefile b/policycoreutils/setsebool/Makefile
> index 556b780..1b89d5c 100644
> --- a/policycoreutils/setsebool/Makefile
> +++ b/policycoreutils/setsebool/Makefile
> @@ -7,7 +7,7 @@ LIBDIR ?= ${PREFIX}/lib
>
> CFLAGS ?= -Werror -Wall -W
> override CFLAGS += -I$(INCLUDEDIR)
> -LDLIBS = -lsepol -lselinux -lsemanage -L$(LIBDIR)
> +LDLIBS = -lsepol -lselinux -lsemanage -lbz2 -lustr -L$(LIBDIR)
> SETSEBOOL_OBJS = setsebool.o
>
> all: setsebool
>
--
Eamon Walsh
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-03-30 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 21:08 [PATCH] Add implicit lib requirements to LDLIBS Joshua Brindle
2010-03-30 23:34 ` Eamon Walsh [this message]
2010-03-31 13:21 ` Joshua Brindle
2010-03-31 15:15 ` Stephen Smalley
2010-03-31 15:17 ` Stephen Smalley
2010-03-31 15:33 ` Joshua Brindle
2010-03-31 15:34 ` Eamon Walsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB28AA1.9060508@tycho.nsa.gov \
--to=ewalsh@tycho.nsa.gov \
--cc=jbrindle@tresys.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.