From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value
Date: Wed, 31 Mar 2010 08:34:46 +0200 [thread overview]
Message-ID: <4BB2ED06.3010907@denx.de> (raw)
In-Reply-To: <201003310207.56010.vapier@gentoo.org>
only fill the device enetaddr with the contents of the eeprom,
not program it in mac address registers
Signed-off-by: Heiko Schocher <hs@denx.de>
---
- changes since v1 posted here:
http://lists.denx.de/pipermail/u-boot/2010-March/069192.html
- splitted in two patches as Wolfgang suggested
- changes since v2 posted here:
http://lists.denx.de/pipermail/u-boot/2010-March/069244.html
- add comment from Ben and Mike:
- not to look in content from "ethaddr"
- only read the mac from eeprom to ethdevices enetaddr and
do not program it in mac address registers
drivers/net/fec_mxc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 5af9cdb..8c4ade5 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -752,7 +752,6 @@ static int fec_probe(bd_t *bd)
if (fec_get_hwaddr(edev, ethaddr) == 0) {
printf("got MAC address from EEPROM: %pM\n", ethaddr);
memcpy(edev->enetaddr, ethaddr, 6);
- fec_set_hwaddr(edev);
}
return 0;
--
1.6.2.5
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2010-03-31 6:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:46 [U-Boot] [PATCH 1/2 v2] net, fec_mxc: only setup the device enetaddr with eeprom value, if ethaddr is not setup Heiko Schocher
2010-03-30 20:34 ` Wolfgang Denk
2010-03-30 21:57 ` Ben Warren
2010-03-30 21:59 ` Mike Frysinger
2010-03-30 22:16 ` Ben Warren
2010-03-31 5:56 ` Heiko Schocher
2010-03-31 6:07 ` Mike Frysinger
2010-03-31 6:34 ` Heiko Schocher [this message]
2010-03-31 6:50 ` [U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value Ben Warren
2010-03-31 8:34 ` Wolfgang Denk
2010-03-31 8:41 ` Wolfgang Denk
2010-05-03 2:38 ` [U-Boot] Toggling pins using the BDI3000 Can Aydin
2010-03-31 6:34 ` [U-Boot] [PATCH] net, doc: how to setup mac address correct Heiko Schocher
2010-03-31 8:50 ` Wolfgang Denk
2010-03-31 13:44 ` [U-Boot] [PATCH 1/2 v2] net, fec_mxc: only setup the device enetaddr with eeprom value, if ethaddr is not setup Detlev Zundel
2010-03-31 13:58 ` Ben Warren
2010-03-31 14:46 ` Detlev Zundel
2010-03-31 19:59 ` Mike Frysinger
2010-03-31 20:04 ` Ben Warren
2010-03-31 9:18 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB2ED06.3010907@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.