From: Nishanth Menon <menon.nishanth@gmail.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@deeprootsystems.com,
paul@pwsan.com, b-cousson@ti.com, vishwanath.bs@ti.com,
sawant@ti.com
Subject: Re: [PATCHv2 1/3] OMAP3: PM: Fix crash when enabling SmartReflex on non-supported OMAPs.
Date: Wed, 31 Mar 2010 06:07:35 -0500 [thread overview]
Message-ID: <4BB32CF7.9000309@gmail.com> (raw)
In-Reply-To: <1270017014-27704-2-git-send-email-thara@ti.com>
Thara Gopinath said the following on 03/31/2010 01:30 AM:
> This patch sets and unsets is_sr_reset is appropriate places so that
> trying to enable smart reflex in a non-supported OMAP chip does not
> lead to unnecessary crash. Basically today if sr_enable fails,
> sr_disable will crash due to accessing sr registers when sr clocks
> are not turned on. By checking on is_sr_reset flag and setting and
> unsetting this flag appropriately this crash is fixed in this
> patch.
>
>
>
I think this may belong in your first series -
34xx patchset as this does not have much to do with 3630..
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2010-03-31 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 6:30 [PATCHv2 0/3] OMAP3: PM: OMAP3630 support for smartreflex driver Thara Gopinath
2010-03-31 6:30 ` [PATCHv2 1/3] OMAP3: PM: Fix crash when enabling SmartReflex on non-supported OMAPs Thara Gopinath
2010-03-31 6:30 ` [PATCHv2 2/3] OMAP3: PM: Smartreflex IP update changes for OMAP3630 Thara Gopinath
2010-03-31 6:30 ` [PATCHv2 3/3] OMAP3: PM: Adding OMAP3630 support in smartreflex driver Thara Gopinath
2010-03-31 11:05 ` Nishanth Menon
2010-03-31 11:07 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB32CF7.9000309@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=b-cousson@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sawant@ti.com \
--cc=thara@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.