From: Jonathan Cameron <jic23@cam.ac.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] V3, TI ads7871 a/d converter,
Date: Wed, 31 Mar 2010 15:55:54 +0000 [thread overview]
Message-ID: <4BB3708A.3030608@cam.ac.uk> (raw)
In-Reply-To: <1269124170-11623-1-git-send-email-pthomas8589@gmail.com>
On 03/31/10 16:02, Paul Thomas wrote:
> Great, just a couple of responses.
>
...
>>> +static const struct attribute_group ads7871_group = {
>>> + .attrs = ads7871_attributes,
>>> +};
>>> +
>>> +static int __devinit ads7871_probe(struct spi_device *spi)
>>> +{
>>> + int status, ret, err = 0;
>>> + uint8_t val;
>>> + struct ads7871_data *pdata;
>>> +
>> There is still a lot of debug code in here that is useful for development
>> but probably doesn't want to be in the final driver.
> I'm happy with what you think is best, but in other driver I've been
> glad to have a little bit in demesg.
Fair enough. How much you report tends to be a personal decision, so
it's fine with me as is.
Jonathan
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-03-31 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 22:29 [lm-sensors] [PATCH] V3, TI ads7871 a/d converter, Paul Thomas
2010-03-31 14:52 ` Jonathan Cameron
2010-03-31 15:02 ` Paul Thomas
2010-03-31 15:45 ` Jean Delvare
2010-03-31 15:51 ` Jonathan Cameron
2010-03-31 15:55 ` Jonathan Cameron [this message]
2010-04-05 18:57 ` Paul Thomas
2010-04-06 12:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB3708A.3030608@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.