From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jamal <hadi@cyberus.ca>, Timo Teras <timo.teras@iki.fi>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead
Date: Wed, 31 Mar 2010 18:41:44 +0200 [thread overview]
Message-ID: <4BB37B48.5020308@trash.net> (raw)
In-Reply-To: <20100331135331.GB14082@gondor.apana.org.au>
Herbert Xu wrote:
> On Wed, Mar 31, 2010 at 09:28:12AM -0400, jamal wrote:
>> -sudo ip route add 192.168.11.100 dev eth0 table 15
>> generates an event
>> -sudo ip route flush table 15
>> generates an event
>> -sudo ip route flush table 15
>> No event
>
> That's completely different. We don't have a route flush event,
> instead we're sending route delete events. That's why when the
> table is empty you get no events.
>
> If we had a route flush event then it would behave exactly the
> same.
I was just about to say the exact same thing when I noticed your
email. I agree with Herbert, the flush notification indicates that
the table is now empty, independant of its previous state.
next prev parent reply other threads:[~2010-03-31 16:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 10:17 [PATCH 0/4] xfrm fixes and flow structurization Timo Teras
2010-03-31 10:17 ` Timo Teras
2010-03-31 10:17 ` [PATCH 1/4] xfrm: increment genid before bumping state genids Timo Teras
2010-03-31 10:50 ` Herbert Xu
2010-03-31 10:55 ` Timo Teräs
2010-03-31 11:01 ` Timo Teräs
2010-03-31 11:19 ` Herbert Xu
2010-03-31 11:24 ` Timo Teräs
2010-03-31 10:17 ` [PATCH 2/4] xfrm_user: verify policy direction at XFRM_MSG_POLEXPIRE handler Timo Teras
2010-03-31 10:54 ` Herbert Xu
2010-03-31 10:17 ` [PATCH 3/4] xfrm: remove policy lock when accessing policy->walk.dead Timo Teras
2010-03-31 11:03 ` Herbert Xu
2010-03-31 13:06 ` jamal
2010-03-31 13:11 ` Herbert Xu
2010-03-31 13:26 ` Herbert Xu
2010-03-31 13:32 ` jamal
2010-03-31 13:39 ` jamal
2010-03-31 13:41 ` jamal
2010-03-31 13:56 ` Herbert Xu
2010-03-31 14:15 ` jamal
2010-03-31 20:54 ` David Miller
2010-03-31 13:55 ` Herbert Xu
2010-03-31 14:12 ` jamal
2010-03-31 14:15 ` Herbert Xu
2010-03-31 14:24 ` jamal
2010-03-31 14:29 ` Herbert Xu
2010-03-31 14:38 ` jamal
2010-03-31 20:57 ` David Miller
2010-04-01 0:22 ` Herbert Xu
2010-04-01 2:19 ` jamal
2010-04-01 10:53 ` jamal
2010-03-31 13:28 ` jamal
2010-03-31 13:53 ` Herbert Xu
2010-03-31 16:41 ` Patrick McHardy [this message]
2010-03-31 17:47 ` jamal
2010-04-01 11:24 ` Patrick McHardy
2010-03-31 20:52 ` David Miller
2010-03-31 10:17 ` [PATCH 4/4] flow: structurize flow cache Timo Teras
2010-03-31 11:21 ` Herbert Xu
2010-04-02 2:42 ` [PATCH 0/4] xfrm fixes and flow structurization David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB37B48.5020308@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.