From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nx3oC-0006HM-Bj for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:42:36 -0400 Received: from [140.186.70.92] (port=40567 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nx3oA-0006Gu-Pq for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nx3o7-0001uJ-UF for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:42:34 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:35966) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nx3o7-0001u8-KT for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:42:31 -0400 Received: by pvc21 with SMTP id 21so43156pvc.4 for ; Wed, 31 Mar 2010 12:42:30 -0700 (PDT) Message-ID: <4BB3A5A3.7000106@codemonkey.ws> Date: Wed, 31 Mar 2010 14:42:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] vhost: fix features ack References: <20100331182031.GA5200@redhat.com> <4BB393CF.1040700@codemonkey.ws> <20100331153805.03ee142e@redhat.com> <20100331190753.GA6914@redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------080509010507040706000608" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Luiz Capitulino , qemu-devel@nongnu.org, "Michael S. Tsirkin" This is a multi-part message in MIME format. --------------080509010507040706000608 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/31/2010 02:38 PM, Blue Swirl wrote: > On 3/31/10, Michael S. Tsirkin wrote: > >> On Wed, Mar 31, 2010 at 03:38:05PM -0300, Luiz Capitulino wrote: >> > On Wed, 31 Mar 2010 13:26:23 -0500 >> > Anthony Liguori wrote: >> > >> > > On 03/31/2010 01:20 PM, Michael S. Tsirkin wrote: >> > > > From: David L Stevens >> > > > >> > > > vhost driver in qemu didn't ack features, and this happens >> > > > to work because we don't really require any features. However, >> > > > it's better not to rely on this. This patch passes features to >> > > > vhost as guest acks them. >> > > > >> > > > Signed-off-by: David L Stevens >> > > > Signed-off-by: Michael S. Tsirkin >> > > > --- >> > > > >> > > > Anthony, here's a fixup patch to address an issue in vhost >> > > > patches. Incidentially, what's the status of the vhost patchset? >> > > > >> > > >> > > http://repo.or.cz/w/qemu/aliguori-queue.git vhost >> > > >> > > Is what I'm currently testing. With vhost disabled, the following seg >> > > faults: >> > > >> > > qemu-system-x86_64 -hda ~/images/linux.img -net tap -net >> > > nic,model=virtio -enable-kvm >> > > >> > > But not when using TCG. I'm not sure that it's your patches at fault >> > > and I'm attempting to bisect now to figure that out. >> > >> > Probably this is the same segfault I'm getting right now in master, >> > bisect says it's: >> > >> > """ >> > commit ad96090a01d848df67d70c5259ed8aa321fa8716 >> > Author: Blue Swirl >> > Date: Mon Mar 29 19:23:52 2010 +0000 >> > >> > Refactor target specific handling, compile vl.c only once >> > """ >> >> Why are the compile once patches helpful? They seem to introduce >> churn and bugs, they actively make it harder to extend qemu as you can't use >> target-specific code in code that is compiled once, they might have >> performance penalty - and what do we gain? Any given user is unlikely to >> need to build on more than one target, distros have enough computing >> power to build in parallel. >> > As has been explained many times, knowledge about CPU specific > features has no place in devices. Actively removing CPU specifics from > devices is good but preventing new bad code to be committed is better. > > I don't have distro computing powers (unless some distro's compute > center only has two low power machines) and I guess some other > developers don't have either. All developers and patch submitters are > expected to compile all targets. This patch set has decreased the > number of files compiled by about 20%. > BTW, this seems to do it. I'll commit after some testing. Regards, Anthony Liguori --------------080509010507040706000608 Content-Type: text/plain; name="0001-Fix-enable-kvm.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-enable-kvm.patch" RnJvbSA3YzE5MjBkMzMwZmNmN2VkNWI0NzdiYzhlMjJjYTRmN2U1ZTJiMzQzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IExpZ3VvcmkgPGFsaWd1b3JpQHVzLmli bS5jb20+CkRhdGU6IFdlZCwgMzEgTWFyIDIwMTAgMTQ6MjA6MTEgLTA1MDAKU3ViamVjdDog W1BBVENIXSBGaXggLWVuYWJsZS1rdm0KCmNvbW1pdCBhZDk2MDkwYTAxZDg0OGRmNjdkNzBj NTI1OWVkOGFhMzIxZmE4NzE2CkF1dGhvcjogQmx1ZSBTd2lybCA8YmxhdXdpcmJlbEBnbWFp bC5jb20+CkRhdGU6ICAgTW9uIE1hciAyOSAxOToyMzo1MiAyMDEwICswMDAwCgogICAgUmVm YWN0b3IgdGFyZ2V0IHNwZWNpZmljIGhhbmRsaW5nLCBjb21waWxlIHZsLmMgb25seSBvbmNl CgpJbnRyb2R1Y2VkIGEgcmVncmVzc2lvbiBpbiAtZW5hYmxlLWt2bSBiZWNhdXNlIGl0IGxl ZnQgQ09ORklHX0tWTSBpbiBrdm0uaAp3aGlsZSBhbGxvd2luZyBjb21waWxlZC1vbmNlIG9i amVjdHMgdG8gdXNlIGt2bS5oLiAgQ09ORklHX0tWTSBpcyBzZXQgb24gYQpwZXItdGFyZ2V0 IGJhc2lzLgoKY29tbWl0IDUzYjY3YjMwNTJmMzliMDQ5YmM3Yzc5YWUxY2UxMzJjOTAwOThj NmMKQXV0aG9yOiBCbHVlIFN3aXJsIDxibGF1d2lyYmVsQGdtYWlsLmNvbT4KRGF0ZTogICBN b24gTWFyIDI5IDE5OjIzOjUyIDIwMTAgKzAwMDAKCiAgICBDb21waWxlIGFjcGkgb25seSBv bmNlCgpBbHNvIHJlZ3Jlc3NlZCAtZW5hYmxlLWt2bSBiZWNhdXNlIG9mIGEgdGhpbmtvLgoK T25jZSB3ZSBtYWtlIHRoZXNlIGNoYW5nZXMsIHRoZSBpZigwKSBtYWdpYyBvZiBrdm1fZW5h YmxlZCgpIG5vIGxvbmdlciB3b3JrcwpzbyB3ZSBuZWVkIGVtcHR5IHN0dWIgZnVuY3Rpb25z LgoKU2lnbmVkLW9mZi1ieTogQW50aG9ueSBMaWd1b3JpIDxhbGlndW9yaUB1cy5pYm0uY29t PgotLS0KIGh3L2FjcGkuYyAgICAgfCAgICAzICstCiBrdm0tZ2VuZXJpYy5jIHwgIDEzMyAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKIGt2bS5oICAgICAgICAgfCAgICA5ICsrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMTM5IGlu c2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQga3ZtLWdl bmVyaWMuYwoKZGlmZiAtLWdpdCBhL2h3L2FjcGkuYyBiL2h3L2FjcGkuYwppbmRleCAzM2M2 YmM4Li41YzAxYzJlIDEwMDY0NAotLS0gYS9ody9hY3BpLmMKKysrIGIvaHcvYWNwaS5jCkBA IC01MjksNyArNTI5LDggQEAgaTJjX2J1cyAqcGlpeDRfcG1faW5pdChQQ0lCdXMgKmJ1cywg aW50IGRldmZuLCB1aW50MzJfdCBzbWJfaW9fYmFzZSwKIAogICAgIHJlZ2lzdGVyX2lvcG9y dF93cml0ZShBQ1BJX0RCR19JT19BRERSLCA0LCA0LCBhY3BpX2RiZ193cml0ZWwsIHMpOwog Ci0gICAgaWYgKGt2bV9lbmFibGVkKSB7CisgICAgcy0+a3ZtX2VuYWJsZWQgPSBrdm1fZW5h YmxlZDsKKyAgICBpZiAocy0+a3ZtX2VuYWJsZWQpIHsKICAgICAgICAgLyogTWFyayBTTU0g YXMgYWxyZWFkeSBpbml0ZWQgdG8gcHJldmVudCBTTU0gZnJvbSBydW5uaW5nLiAgS1ZNIGRv ZXMgbm90CiAgICAgICAgICAqIHN1cHBvcnQgU01NIG1vZGUuICovCiAgICAgICAgIHBjaV9j b25mWzB4NUJdID0gMHgwMjsKZGlmZiAtLWdpdCBhL2t2bS1nZW5lcmljLmMgYi9rdm0tZ2Vu ZXJpYy5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmM2N2ZiNTUKLS0t IC9kZXYvbnVsbAorKysgYi9rdm0tZ2VuZXJpYy5jCkBAIC0wLDAgKzEsMTMzIEBACisvKgor ICogUUVNVSBLVk0gc3VwcG9ydAorICoKKyAqIENvcHlyaWdodCBJQk0sIENvcnAuIDIwMTAK KyAqICAgICAgICAgICBSZWQgSGF0LCBJbmMuIDIwMDgKKyAqCisgKiBBdXRob3JzOgorICog IEFudGhvbnkgTGlndW9yaSAgIDxhbGlndW9yaUB1cy5pYm0uY29tPgorICogIEdsYXViZXIg Q29zdGEgICAgIDxnY29zdGFAcmVkaGF0LmNvbT4KKyAqCisgKiBUaGlzIHdvcmsgaXMgbGlj ZW5zZWQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR1BMLCB2ZXJzaW9uIDIgb3IgbGF0 ZXIuCisgKiBTZWUgdGhlIENPUFlJTkcgZmlsZSBpbiB0aGUgdG9wLWxldmVsIGRpcmVjdG9y eS4KKyAqCisgKi8KKworI2luY2x1ZGUgInFlbXUtY29tbW9uLmgiCisjaW5jbHVkZSAiY3B1 LmgiCisjaW5jbHVkZSAia3ZtLmgiCisKK2ludCBrdm1faW5pdChpbnQgc21wX2NwdXMpCit7 CisgICAgcmV0dXJuIC1FTk9TWVM7Cit9CisKK2ludCBrdm1faW5pdF92Y3B1KENQVVN0YXRl ICplbnYpCit7CisgICAgcmV0dXJuIC1FTk9TWVM7Cit9CisKK2ludCBrdm1fY3B1X2V4ZWMo Q1BVU3RhdGUgKmVudikKK3sKKyAgICByZXR1cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV9s b2dfc3RhcnQodGFyZ2V0X3BoeXNfYWRkcl90IHBoeXNfYWRkciwgcmFtX2FkZHJfdCBzaXpl KQoreworICAgIHJldHVybiAtRU5PU1lTOworfQorCitpbnQga3ZtX2xvZ19zdG9wKHRhcmdl dF9waHlzX2FkZHJfdCBwaHlzX2FkZHIsIHJhbV9hZGRyX3Qgc2l6ZSkKK3sKKyAgICByZXR1 cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV9oYXNfc3luY19tbXUodm9pZCkKK3sKKyAgICBy ZXR1cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV9oYXNfdmNwdV9ldmVudHModm9pZCkKK3sK KyAgICByZXR1cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV9oYXNfcm9idXN0X3NpbmdsZXN0 ZXAodm9pZCkKK3sKKyAgICByZXR1cm4gLUVOT1NZUzsKK30KKwordm9pZCBrdm1fc2V0dXBf Z3Vlc3RfbWVtb3J5KHZvaWQgKnN0YXJ0LCBzaXplX3Qgc2l6ZSkKK3sKK30KKworaW50IGt2 bV9jb2FsZXNjZV9tbWlvX3JlZ2lvbih0YXJnZXRfcGh5c19hZGRyX3Qgc3RhcnQsIHJhbV9h ZGRyX3Qgc2l6ZSkKK3sKKyAgICByZXR1cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV91bmNv YWxlc2NlX21taW9fcmVnaW9uKHRhcmdldF9waHlzX2FkZHJfdCBzdGFydCwgcmFtX2FkZHJf dCBzaXplKQoreworICAgIHJldHVybiAtRU5PU1lTOworfQorCit2b2lkIGt2bV9mbHVzaF9j b2FsZXNjZWRfbW1pb19idWZmZXIodm9pZCkKK3sKK30KKworaW50IGt2bV9pbnNlcnRfYnJl YWtwb2ludChDUFVTdGF0ZSAqY3VycmVudF9lbnYsIHRhcmdldF91bG9uZyBhZGRyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICB0YXJnZXRfdWxvbmcgbGVuLCBpbnQgdHlwZSkKK3sK KyAgICByZXR1cm4gLUVOT1NZUzsKK30KKworaW50IGt2bV9yZW1vdmVfYnJlYWtwb2ludChD UFVTdGF0ZSAqY3VycmVudF9lbnYsIHRhcmdldF91bG9uZyBhZGRyLAorICAgICAgICAgICAg ICAgICAgICAgICAgICB0YXJnZXRfdWxvbmcgbGVuLCBpbnQgdHlwZSkKK3sKKyAgICByZXR1 cm4gLUVOT1NZUzsKK30KKwordm9pZCBrdm1fcmVtb3ZlX2FsbF9icmVha3BvaW50cyhDUFVT dGF0ZSAqY3VycmVudF9lbnYpCit7Cit9CisKK2ludCBrdm1fdXBkYXRlX2d1ZXN0X2RlYnVn KENQVVN0YXRlICplbnYsIHVuc2lnbmVkIGxvbmcgcmVpbmplY3RfdHJhcCkKK3sKKyAgICBy ZXR1cm4gLUVOT1NZUzsKK30KKworI2lmbmRlZiBfV0lOMzIKK2ludCBrdm1fc2V0X3NpZ25h bF9tYXNrKENQVVN0YXRlICplbnYsIGNvbnN0IHNpZ3NldF90ICpzaWdzZXQpCit7CisgICAg cmV0dXJuIC1FTk9TWVM7Cit9CisjZW5kaWYKKworaW50IGt2bV9waXRfaW5fa2VybmVsKHZv aWQpCit7CisgICAgcmV0dXJuIC1FTk9TWVM7Cit9CisKK2ludCBrdm1faXJxY2hpcF9pbl9r ZXJuZWwodm9pZCkKK3sKKyAgICByZXR1cm4gLUVOT1NZUzsKK30KKwordm9pZCBrdm1fY3B1 X3N5bmNocm9uaXplX3N0YXRlKENQVVN0YXRlICplbnYpCit7Cit9CisKK3ZvaWQga3ZtX2Nw dV9zeW5jaHJvbml6ZV9wb3N0X3Jlc2V0KENQVVN0YXRlICplbnYpCit7Cit9CisKK3ZvaWQg a3ZtX2NwdV9zeW5jaHJvbml6ZV9wb3N0X2luaXQoQ1BVU3RhdGUgKmVudikKK3sKK30KKwor LyogVGhpcyBpcyBldmlsIGJ1dCB0aGUgS1ZNIFBQQyBjb2RlIG5lZWRzIHJlZmFjdG9yaW5n ICovCit2b2lkIGt2bXBwY19pbml0KHZvaWQpOworCit2b2lkIGt2bXBwY19pbml0KHZvaWQp Cit7Cit9CmRpZmYgLS1naXQgYS9rdm0uaCBiL2t2bS5oCmluZGV4IDRmNzcxODguLjlmNTdm ZDUgMTAwNjQ0Ci0tLSBhL2t2bS5oCisrKyBiL2t2bS5oCkBAIC0xOSwxMSArMTksMTAgQEAK IAogZXh0ZXJuIGludCBrdm1fYWxsb3dlZDsKIAotI2lmZGVmIENPTkZJR19LVk0KLSNkZWZp bmUga3ZtX2VuYWJsZWQoKSAoa3ZtX2FsbG93ZWQpCi0jZWxzZQotI2RlZmluZSBrdm1fZW5h YmxlZCgpICgwKQotI2VuZGlmCitzdGF0aWMgaW5saW5lIGludCBrdm1fZW5hYmxlZCh2b2lk KQoreworICAgIHJldHVybiBrdm1fYWxsb3dlZDsKK30KIAogc3RydWN0IGt2bV9ydW47CiAK LS0gCjEuNi41LjIKCg== --------------080509010507040706000608--