All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: exit non-0 if fs check fails
Date: Wed, 31 Mar 2010 20:25:49 -0500	[thread overview]
Message-ID: <4BB3F61D.3020507@sandeen.net> (raw)
In-Reply-To: <20100401001956.GL7671@dastard>

Dave Chinner wrote:
> On Wed, Mar 31, 2010 at 06:38:23PM -0500, Eric Sandeen wrote:
>> Right now if any of the _check_scratch_fs tests etc fail,
>> the check script exits but with 0 status.
>>
>> This change will cause the status to be non-0 so we can detect
>> the error.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> 
> Wouldn't it be better to do:
> 
> -   [ $ok -eq 0 ] && exit 1
> +    if [ $ok -eq 0 ]; then
> +	status=1
> +	exit 1
> +    fi
> 
> To catch all failures rather than just the fsck failure?

sure, that sounds better.  I'll check that version in w/ your SOB
unless I hear otherwise :)

Thanks,
-Eric

>> ---
>>
>> (aside - we could make it 2 instead of 1, so that a calling script
>> could fsck and continue ... thoughts?)
> 
> I think if a test corrupts a filesystem, the test run should stop
> so the failure can be analysed without needing to reproduce it
> again...
> 
> Cheers,
> 
> Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-04-01  1:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31 23:38 [PATCH] xfstests: exit non-0 if fs check fails Eric Sandeen
2010-04-01  0:19 ` Dave Chinner
2010-04-01  1:25   ` Eric Sandeen [this message]
2010-04-15 19:29     ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB3F61D.3020507@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.