All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dimitris Michailidis <dm@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/6] cxgb4: Add main driver file and driver Makefile
Date: Wed, 31 Mar 2010 18:34:31 -0700	[thread overview]
Message-ID: <4BB3F827.3010402@chelsio.com> (raw)
In-Reply-To: <20100331.172401.00333850.davem@davemloft.net>

David Miller wrote:

>> So, I propose getting rid of 3-4 of these files that are of lesser
>> value and moving the rest to debugfs for now.  If some alternative
>> through ethtool or something becomes available I can get rid of
>> anything that can be handled through a more general facility.  Would
>> that be acceptable?
> 
> You can use sysfs.

sysfs is a possibility but I thought Stephen's initial concern was that I 
was adding too many of these proc files and that they were creating a 
potential API.  sysfs will result in a lot more files with its 
value-per-file model and I think sysfs and proc are similar in "APIness". 
So it's not clear to me how going to sysfs would address Stephen's point. 
The remove-a-few plus move-to-debugfs proposal was in order to end up with 
fewer files in a non-API filesystem.

As these builtin switches become more common I expect an official way to 
represent and access them will emerge but maybe it's not a good idea to 
introduce a sysfs model for them as part of this driver submission.

  reply	other threads:[~2010-04-01  1:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 18:52 [PATCH 0/6] updated cxgb4 submission Dimitris Michailidis
2010-03-30 18:52 ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Dimitris Michailidis
2010-03-30 18:52   ` [PATCH 2/6] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-03-30 18:52     ` [PATCH 3/6] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-03-30 18:52       ` [PATCH 4/6] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-03-30 18:52         ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis
2010-03-30 18:52           ` [PATCH 6/6] net: Hook up cxgb4 to Kconfig and Makefile Dimitris Michailidis
2010-03-30 21:19           ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Stephen Hemminger
2010-03-31  1:34             ` Dimitris Michailidis
2010-03-31  5:50             ` David Miller
2010-03-31 19:31               ` Steve Wise
2010-03-31 21:13                 ` David Miller
2010-04-01  0:19               ` Dimitris Michailidis
2010-04-01  0:24                 ` David Miller
2010-04-01  1:34                   ` Dimitris Michailidis [this message]
2010-04-01  2:18                     ` David Miller
2010-03-30 21:09   ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Stephen Hemminger
2010-03-31  1:25     ` Dimitris Michailidis
  -- strict thread matches above, loose matches on Subject: below --
2010-04-02  1:28 [PATCH 0/6] updated cxgb4 submission v6 Dimitris Michailidis
2010-04-02  1:28 ` [PATCH 1/6] cxgb4: Add register, message, and FW definitions Dimitris Michailidis
2010-04-02  1:28   ` [PATCH 2/6] cxgb4: Add HW and FW support code Dimitris Michailidis
2010-04-02  1:28     ` [PATCH 3/6] cxgb4: Add packet queues and packet DMA code Dimitris Michailidis
2010-04-02  1:28       ` [PATCH 4/6] cxgb4: Add remaining driver headers and L2T management Dimitris Michailidis
2010-04-02  1:28         ` [PATCH 5/6] cxgb4: Add main driver file and driver Makefile Dimitris Michailidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB3F827.3010402@chelsio.com \
    --to=dm@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.