From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Andreas Henriksson <andreas@fatal.se>, jamal <hadi@cyberus.ca>,
netdev@vger.kernel.org
Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers
Date: Thu, 01 Apr 2010 14:06:40 +0200 [thread overview]
Message-ID: <4BB48C50.2000000@trash.net> (raw)
In-Reply-To: <n2ib6fcc0a1004010502z8c25a68cg11c5aa2f90ad4826@mail.gmail.com>
Alexey Dobriyan wrote:
> On Thu, Apr 1, 2010 at 1:50 PM, Patrick McHardy <kaber@trash.net> wrote:
>> I can't think of anything but to restore the XT_ALIGN macro.
>> We could add a XT_ALIGN definition to xtables.h, but that might
>> still leave problems for other users.
>>
>> Alexey, do you have any better suggestions?
>
> I like __KERNEL_ALIGN trick.
>
> Sorry for attachment, my patch sending facility is broke.
> Tested on iptables compilation.
>
Seems fine to me, thanks. I'll wait a bit for others to comment.
next prev parent reply other threads:[~2010-04-01 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 12:02 [PATCH] xtables: make XT_ALIGN() usable in exported headers Alexey Dobriyan
2010-04-01 12:06 ` Patrick McHardy [this message]
2010-04-01 12:25 ` "YOSHIFUJI Hideaki (吉藤 英明)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB48C50.2000000@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=andreas@fatal.se \
--cc=bhutchings@solarflare.com \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.