From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] xtables: make XT_ALIGN() usable in exported headers Date: Thu, 01 Apr 2010 14:06:40 +0200 Message-ID: <4BB48C50.2000000@trash.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Ben Hutchings , Andreas Henriksson , jamal , netdev@vger.kernel.org To: Alexey Dobriyan Return-path: Received: from stinky.trash.net ([213.144.137.162]:50911 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753487Ab0DAMGm (ORCPT ); Thu, 1 Apr 2010 08:06:42 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Alexey Dobriyan wrote: > On Thu, Apr 1, 2010 at 1:50 PM, Patrick McHardy wrote: >> I can't think of anything but to restore the XT_ALIGN macro. >> We could add a XT_ALIGN definition to xtables.h, but that might >> still leave problems for other users. >> >> Alexey, do you have any better suggestions? > > I like __KERNEL_ALIGN trick. > > Sorry for attachment, my patch sending facility is broke. > Tested on iptables compilation. > Seems fine to me, thanks. I'll wait a bit for others to comment.