From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Cc: "Richard W.M. Jones" <rjones@redhat.com>
Subject: [PATCH] mke2fs: be explicit if external journal device is not found
Date: Thu, 01 Apr 2010 14:26:30 -0500 [thread overview]
Message-ID: <4BB4F366.9030404@redhat.com> (raw)
This for RH bug #572935 -
RFE: Misleading error message from mke2fs -J option
If the journal device UUID is typo'd or otherwise not found,
the error message looks like it's a usage() type of problem.
It'd be helpful to explicitly say that the device requested
could not be found.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/misc/util.c b/misc/util.c
index b8a3cac..51bdb60 100644
--- a/misc/util.c
+++ b/misc/util.c
@@ -207,6 +207,10 @@ void parse_journal_opts(const char *opts)
if (strcmp(token, "device") == 0) {
journal_device = blkid_get_devname(NULL, arg, NULL);
if (!journal_device) {
+ if (arg)
+ fprintf(stderr, _("\nCould not find "
+ "journal device matching %s\n"),
+ arg);
journal_usage++;
continue;
}
next reply other threads:[~2010-04-01 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 19:26 Eric Sandeen [this message]
2010-05-12 16:54 ` [PATCH] mke2fs: be explicit if external journal device is not found tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB4F366.9030404@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.