From: Yinghai Lu <yinghai@kernel.org>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Peter Jones <pjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] ibft, x86: Change reserve_ibft_region() to find_ibft_region()
Date: Thu, 01 Apr 2010 13:59:36 -0700 [thread overview]
Message-ID: <4BB50938.9040000@kernel.org> (raw)
In-Reply-To: <20100401201206.GA19462@andromeda.dapyr.net>
On 04/01/2010 01:12 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 31, 2010 at 07:07:32PM -0700, Yinghai Lu wrote:
>>
>>
>> So arch code could decide the way to reserve the ibft.
>>
>> And We should reserve ibft as early as possible, instead of BOOTMEM stage,
>> in case the table is in RAM range and is not reserved by BIOS.
>
> What test vehicle did you use to find this bug?
code review for CONFIG_NO_BOOTMEM
reserve_bootmem() should only be used for converting entries reserved by reserved_early()
so When we are using CONFIG_NO_BOOTMEM, reserve_bootmem() is killed.
>
>
> .. snip..
>> + if (size)
>> + reserve_early_overlap_ok(addr, addr + size, "ifbt");
> ^^^^ - ibft
thanks, will change it.
Yinghai
next prev parent reply other threads:[~2010-04-01 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 2:07 [PATCH] ibft, x86: Change reserve_ibft_region() to find_ibft_region() Yinghai Lu
2010-04-01 20:12 ` Konrad Rzeszutek Wilk
2010-04-01 20:59 ` Yinghai Lu [this message]
2010-04-01 21:32 ` [PATCH -v2] " Yinghai Lu
2010-04-01 21:54 ` Randy Dunlap
2010-04-01 22:00 ` Yinghai Lu
2010-04-01 22:03 ` Randy Dunlap
2010-04-01 23:51 ` [tip:x86/urgent] " tip-bot for Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB50938.9040000@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=konrad@darnok.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=pjones@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.