From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxhtc-00060O-PB
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 10:30:52 -0400
Received: from [140.186.70.92] (port=44407 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxhtb-0005zn-JH
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 10:30:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1NxhtZ-00012N-Q9
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 10:30:51 -0400
Received: from moutng.kundenserver.de ([212.227.126.171]:64797)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1NxhtZ-00011r-Dj
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 10:30:49 -0400
Message-ID: <4BB5FF88.8090100@mail.berlios.de>
Date: Fri, 02 Apr 2010 16:30:32 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [BREAKAGE]
	commit	9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
References: <u2t473191351004020238u1b31133bmf764d10c41c23b29@mail.gmail.com>	<r2yf085eb031004020515je593d880j8a5eb9103b36f96f@mail.gmail.com>	<p2x473191351004020516ie46a703az6f42e3df14cba87f@mail.gmail.com>
	<h2xf43fc5581004020709k4ce41a1bxf93ef86cb12da493@mail.gmail.com>
In-Reply-To: <h2xf43fc5581004020709k4ce41a1bxf93ef86cb12da493@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Roy Tam <roytam@gmail.com>

Blue Swirl schrieb:
> On 4/2/10, Roy Tam <roytam@gmail.com> wrote:
>> 2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
>>
>>> Try doing a clean build
>>
>> This is a fresh checkout.
>
> I can confirm this with mingw32:
> LINK sparc64-softmmu/qemu-system-sparc64.exe
> virtio-net.o: In function `virtio_net_exit':
> /src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_save':
> /src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_reset':
> /src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_set_status':
> /src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
> /src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
> virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
> to `_tap_get_vhost_net' follow
> collect2: ld returned 1 exit status

A cross build (mingw32 on debian) also results in this linker error.
The reason is quite simple: tap.o (which provides tap_get_vhost_net)
is only build for posix systems, but not for windows:

Makefile.objs:net-nested-$(CONFIG_POSIX) += tap.o

Changing this does not help because tap.c does not
compile for win32 without errors. Either these errors
have to be fixed, or don't call tap_get_vhost_net when
compiling for win32.

Stefan