From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxiX4-0001tX-5m for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:11:38 -0400 Received: from [140.186.70.92] (port=52626 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxiX3-0001sx-5p for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxiX1-00070h-R2 for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:11:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63343) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxiX1-00070P-Ij for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:11:35 -0400 Message-ID: <4BB60921.5050906@redhat.com> Date: Fri, 02 Apr 2010 17:11:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4BB4FED5.2080508@codemonkey.ws> <4BB606BE.9000508@redhat.com> <4BB6086B.2080009@codemonkey.ws> In-Reply-To: <4BB6086B.2080009@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , qemu-devel On 04/02/2010 05:08 PM, Anthony Liguori wrote: > Having kvm-all.c compile with and without CONFIG_KVM is pretty ugly IMHO. > > Is compiling vl.c once really that important of a goal? I didn't do this to compile vl.c once. I don't care about that. I did this as an initial step towards having kvm functions stubbed out for !CONFIG_KVM, instead of relying on GCC performing dead-code-elimination on kvm_enabled(). Paolo