From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxifx-0007Bn-Jm
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:20:49 -0400
Received: from [140.186.70.92] (port=37918 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxifw-00078v-4G
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:20:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nxifu-00085r-LX
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:20:47 -0400
Received: from mail-pz0-f186.google.com ([209.85.222.186]:41356)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nxifu-00085U-DJ
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 11:20:46 -0400
Received: by pzk16 with SMTP id 16so1834691pzk.22
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 08:20:45 -0700 (PDT)
Message-ID: <4BB60B49.5040407@codemonkey.ws>
Date: Fri, 02 Apr 2010 10:20:41 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <l2vf43fc5581004011307m28f5f783nc27e4350acedef81@mail.gmail.com>	<4BB4FED5.2080508@codemonkey.ws>
	<z2uf43fc5581004011327jfcf55ba6vc866442197896955@mail.gmail.com>
	<4BB606BE.9000508@redhat.com> <4BB6086B.2080009@codemonkey.ws>
	<4BB60921.5050906@redhat.com>
In-Reply-To: <4BB60921.5050906@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c,
	compile  vl.c once
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 04/02/2010 10:11 AM, Paolo Bonzini wrote:
> On 04/02/2010 05:08 PM, Anthony Liguori wrote:
>> Having kvm-all.c compile with and without CONFIG_KVM is pretty ugly 
>> IMHO.
>>
>> Is compiling vl.c once really that important of a goal?
>
> I didn't do this to compile vl.c once.  I don't care about that.
>
> I did this as an initial step towards having kvm functions stubbed out 
> for !CONFIG_KVM, instead of relying on GCC performing 
> dead-code-elimination on kvm_enabled().

I'd prefer a kvm-stub.c implementation as opposed to mixing in 
CONFIG_KVM in kvm-all.c

Regards,

Anthony Liguori

> Paolo