From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NxjJN-0002Mk-Qb
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:01:34 -0400
Received: from [140.186.70.92] (port=56960 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NxjJK-0002MH-K9
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:01:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1NxjJJ-0003MR-7b
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:01:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22073)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1NxjJJ-0003MN-08
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:01:29 -0400
Message-ID: <4BB614D4.2050206@redhat.com>
Date: Fri, 02 Apr 2010 18:01:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <l2vf43fc5581004011307m28f5f783nc27e4350acedef81@mail.gmail.com>	<4BB4FED5.2080508@codemonkey.ws>
	<z2uf43fc5581004011327jfcf55ba6vc866442197896955@mail.gmail.com>
	<4BB606BE.9000508@redhat.com> <4BB6086B.2080009@codemonkey.ws>
	<4BB60921.5050906@redhat.com> <4BB60B49.5040407@codemonkey.ws>
In-Reply-To: <4BB60B49.5040407@codemonkey.ws>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c,
	compile  vl.c once
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 04/02/2010 05:20 PM, Anthony Liguori wrote:
>>
>> I didn't do this to compile vl.c once.  I don't care about that.
>>
>> I did this as an initial step towards having kvm functions stubbed out
>> for !CONFIG_KVM, instead of relying on GCC performing
>> dead-code-elimination on kvm_enabled().
>
> I'd prefer a kvm-stub.c implementation as opposed to mixing in
> CONFIG_KVM in kvm-all.c

I tried it, but our build system makes it a mess because 
compile-once-only can only be done using what once were static 
libraries.  All files from there are added blindly:

    obj-y += $(addprefix ../, $(common-obj-y))
    obj-y += $(addprefix ../libdis/, $(libdis-y))
    obj-y += $(libobj-y)
    obj-y += $(addprefix $(HWDIR)/, $(hw-obj-y))

I'll try something.

Paolo