[Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM

[Paolo Bonzini <pbonzini@redhat.com>]

On 04/02/2010 07:29 PM, Blue Swirl wrote:
> Could you stub also kvm_init?

It is stubbed, but it returns ENOSYS:

  +int kvm_init(int smp_cpus)
  +{
  +    return -ENOSYS;
  +}
  +

and in fact I'm relying this to remove this:

  if (!(kvm_available())) {
      printf("Option %s not supported for this target\n", popt->name);
      exit(1);
  }

and instead looking for an error when I call kvm_init.  I don't see why 
kvm_init should be called if not passing -enable-kvm (which is kvm_allowed).

> Then this part would be simpler because
> you can call unconditionally kvm_init. I guess there would be no need
> to export kvm_allowed for !CONFIG_KVM case.

I don't understand what you mean.  If this doesn't clarify enough, feel 
free to pick up the patch and tweak it; I'm not going to spend much time 
on QEMU for a while.

Paolo