All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: agashi shipora <gashipo@gmail.com>
Cc: Gareth Williams <gwilliams@ubicom.com>, netfilter-devel@vger.kernel.org
Subject: Re: br_netfilter post routing hook question...
Date: Fri, 02 Apr 2010 19:50:57 +0200	[thread overview]
Message-ID: <4BB62E81.707@pandora.be> (raw)
In-Reply-To: <v2q861e3bca1004021026kc7bba6p1a4b615a46e48c29@mail.gmail.com>

agashi shipora wrote:
> Hi,
> 
> I don't know if br_nf_post_routing can be assigned a priority
> NF_BR_PRI_LAST-1. I couldn't find ip_refrag definition in 2.6.30.
> 

The comment about ip_refrag() is outdated. I sent a patch containing an
updated comment to Patrick earlier this week. The priority still has to
be NF_BR_PRI_LAST, because br_nf_post_routing() returns NF_STOLEN.
This is because the function ip_fragment(), which can be called by
br_nf_dev_queue_xmit(), will free the skb. If you won't use connection
tracking, I guess you could alter the code so you can still look at it
after br_nf_post_routing().

cheers,
Bart

-- 
Bart De Schuymer
www.artinalgorithms.be

  parent reply	other threads:[~2010-04-02 17:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02 14:18 br_netfilter post routing hook question Gareth Williams
2010-04-02 17:26 ` agashi shipora
2010-04-02 17:42   ` Gareth Williams
2010-04-02 18:47     ` Bart De Schuymer
2010-04-02 19:15       ` Gareth Williams
2010-04-02 19:55         ` Bart De Schuymer
2010-04-02 19:56           ` Gareth Williams
2010-04-02 17:50   ` Bart De Schuymer [this message]
2010-04-02 17:32 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB62E81.707@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=gashipo@gmail.com \
    --cc=gwilliams@ubicom.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.