From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Nxnlq-0004Gp-OO for mharc-grub-devel@gnu.org; Fri, 02 Apr 2010 16:47:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nxnln-0004Ei-MR for grub-devel@gnu.org; Fri, 02 Apr 2010 16:47:11 -0400 Received: from [140.186.70.92] (port=50249 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nxnlj-0004BD-DM for grub-devel@gnu.org; Fri, 02 Apr 2010 16:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nxnlf-000727-UX for grub-devel@gnu.org; Fri, 02 Apr 2010 16:47:07 -0400 Received: from mail-fx0-f227.google.com ([209.85.220.227]:39243) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nxnlf-000720-Jl for grub-devel@gnu.org; Fri, 02 Apr 2010 16:47:03 -0400 Received: by fxm27 with SMTP id 27so1370139fxm.8 for ; Fri, 02 Apr 2010 13:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=szHlRHC6TBhVUPSBXLEENDmFq4l5hZvCP4/Lm4qhDcc=; b=SABr3gUIvhif4G6wc81T4q7jqwTYjkiD8jzZFe3JvAuPf6uB5GcQr/4FccIHFCuxeY ksRfQh9gMaTTn7rL21cv/g1RV8uqx1u3yJSJxyYGIUeTTdr4XzeiHzK8tmqVIQzNUeTM zQHo9OSfq+lGdjAt6Q6aWazUFsOpotdhwjyzQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=H4wNIgbD0YS+WJjricHRgNNBugOWfScj0F+3NExK9f2MGdPaU56PAfHgeTIjgHGdvV tRNEtCuiFCbu0S2UDDZgSARG2awAhhj1cbFw7+MGlIuQL5kWQAKw33+H9iuj79Px2mD0 R36J0bpttl4wpG9jYDHK97NpsDuONmqGRFtac= Received: by 10.223.1.146 with SMTP id 18mr2445303faf.53.1270241222621; Fri, 02 Apr 2010 13:47:02 -0700 (PDT) Received: from debian.bg45.phnet (222-14.77-83.cust.bluewin.ch [83.77.14.222]) by mx.google.com with ESMTPS id 13sm5960941fks.0.2010.04.02.13.46.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 13:46:59 -0700 (PDT) Message-ID: <4BB657BB.60801@gmail.com> Date: Fri, 02 Apr 2010 22:46:51 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <1268605383.2839.26.camel@homenes1> In-Reply-To: <1268605383.2839.26.camel@homenes1> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig0470E5A047356E6CA65FE23D" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [Patch] [bug #26237] multiple problems with usb devices X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 20:47:11 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0470E5A047356E6CA65FE23D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ale=C5=A1 Nesrsta wrote: > Hello, > > according to e-mail from Vladimir Serbinenko I am sending patch related= > to (mostly) OHCI problem (bug #26237). > Workaround related to grub_memalign problem is removed from patch > because Vladimir Serbinenko wrotes that it will be corrected. > =20 First of all big thanks for debugging this important aspect. And sorry for being busy lately. - GRUB_OHCI_REG_RHUBA =3D 18, - GRUB_OHCI_REG_RHUBPORT =3D 21 + GRUB_OHCI_REG_FRAME_REMAINING, + GRUB_OHCI_REG_FRAME_NUMBER, + GRUB_OHCI_REG_PERIODIC_START, + GRUB_OHCI_REG_LS_TRESHOLD, + GRUB_OHCI_REG_RHUB_DESC_A, Please avoid register renaming unless original ones are misnomers. If they are I would prefer renaming to be a separate patch. - grub_ohci_td_t td_list; + grub_ohci_td_t td_list ; This change is spurious + * So we should: + * - allow WritebackDoneHead interrupt (WDH) by proper setting of last= TD + * token - it is done above in transaction settings + * - detect setting of WDH bit in HcInterruptStatus register + * - compare HccaDoneHead value with address of last-1 TD. If it is no= t + * equal, check ED for halt and if not so, reset WDH bit and wait ag= ain + * - but it should not happen - debug it! Are the comments from you or any part copied from spec. We need no copy f= rom spec as spec is available anyway and sentences copied from it may cau= se copyright problems +/* Self commenting... */ Such comments should be removed, but an empty line at this point would be= nice + err_sense =3D grub_scsi_request_sense (scsi); + /* err_sense is ignored for now and Request Sense Data also... */ When you ignore an error you need to clean grub_errno. Sth like if (!err) grub_errno =3D GRUB_ERR_NONE; grub_scsi_cmd_inquiry =3D 0x12, + grub_scsi_cmd_test_unit_ready =3D 0x00, Please keep this list sorted. -#define GRUB_USB_FEATURE_ENDP_HALT 0x01 -#define GRUB_USB_FEATURE_DEV_REMOTE_WU 0x02 -#define GRUB_USB_FEATURE_TEST_MODE 0x04 +#define GRUB_USB_FEATURE_ENDP_HALT 0x00 +#define GRUB_USB_FEATURE_DEV_REMOTE_WU 0x01 Why do you need to change these constants? Were they wrong? Tomorrow I'll test your patch on both UHCI and OHCI. +#define GRUB_USB_FEATURE_TEST_MODE 0x02 grub_scsi_cmd_read_capacity =3D 0x25, + > Patch was done by: > > diff -urB grub2-1.98~experimental.20100120 grub2-1.98~my_patched.20100= 312 > grub2-1.98~my_patched.20100312.patch > > As I shortly read the patch file, there sometimes remains some few > things which can be optimized - sorry, it is mostly the rest from > debugging experiments (even I make cleaning of code today)... > > Ales > > =20 >> Od: Vladimir Serbinenko >> Komu: Oliver Henshaw , Vladimir Serbinenko >> , Ales Nesrsta , bug-grub@gnu.org= >> P=C5=99edm=C4=9Bt: [bug #26237] multiple problems with usb devices >> Datum: Sat, 13 Mar 2010 22:08:44 +0000 >> >> Update of bug #26237 (project grub): >> >> Release: None =3D> Bazaar - trunk = =20 >> >> _______________________________________________________ >> >> Follow-up Comment #6: >> >> Hello. I found out the problem with grub_memalign. I'll apply the patc= h >> tomorrow. Some of the fixes can go directly in while other require >> investigation and perhaps even copyright assignment. Can you remove al= l >> gratuituous changes (like commenting out dprintfs, adding commented ou= t code >> and change register names) and send patch in unified format (-u option= in >> diff) to grub-devel@gnu.org? Porting code from linux is appropriate on= ly if >> license is compatible and porting was approved by maintainer. Are perh= aps >> interested in coding EHCI? >> >> _______________________________________________________ >> >> Reply to this item at: >> >> >> >> _______________________________________________ >> Message sent via/by Savannah >> http://savannah.gnu.org/ >> >> >> =20 >> ----------------------------------------------------------------------= -- >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig0470E5A047356E6CA65FE23D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAku2V8EACgkQNak7dOguQgkU7AEAgCqHjx8rk+awPwUmmUU7UcXx NF+DzUYY84QUcosRDX4A/RWKT9XiP5ctIGW8nMTMkj6I7ZL0/5q4LGUd0rlpHJXg =H8ck -----END PGP SIGNATURE----- --------------enig0470E5A047356E6CA65FE23D--