All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] DM9000: fix build when debugging is enabled
Date: Sun, 04 Apr 2010 22:22:39 -0700	[thread overview]
Message-ID: <4BB9739F.9090407@gmail.com> (raw)
In-Reply-To: <1269469279-22120-1-git-send-email-vapier@gentoo.org>

Hi Mike,

On 3/24/2010 3:21 PM, Mike Frysinger wrote:
> From: Brent Kandetzki<BrentK@teleco.com>
>
> The debug code uses the gcc __func__ define, but tries to use it as a
> static const string which no longer works.  So treat it like a normal
> printf string argument.
>
> Signed-off-by: Brent Kandetzki<BrentK@teleco.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
>   drivers/net/dm9000x.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> index 73dd335..a7fef56 100644
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -75,7 +75,7 @@ TODO: external MII is not functional, only internal at the moment.
>   #define DM9000_DMP_PACKET(func,packet,length)  \
>   	do { \
>   		int i; 							\
> -		printf(func ": length: %d\n", length);			\
> +		printf("%s: length: %d\n", func, length);		\
>   		for (i = 0; i<  length; i++) {				\
>   			if (i % 8 == 0)					\
>   				printf("\n%s: %02x: ", func, i);	\
>    
An identical patch was applied in December (commit 
076cd24cb4278c125c8f36df386852dc0fcfefae).  Am I missing something?

regards,
Ben

  reply	other threads:[~2010-04-05  5:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 22:21 [U-Boot] [PATCH] DM9000: fix build when debugging is enabled Mike Frysinger
2010-04-05  5:22 ` Ben Warren [this message]
2010-04-06  6:04   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB9739F.9090407@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.