Re: [PATCH 1/4] flow: virtualize flow cache entry methods

["Timo Teräs" <timo.teras@iki.fi>]

Herbert Xu wrote:
> On Mon, Apr 05, 2010 at 04:44:22PM +0800, Herbert Xu wrote:
>>> It might actually make more sense to pass struct flow_cache_object**
>>> so the resolver can twiddle the flow_cache_entry's object. Then it'd
>>> be more explicit that the resolver is replacing entries.
>> Yes that sounds good.
> 
> Alternatively you can pass in a struct flow_cache_entry *.
> 
> Yet another way would be to keep it the same but move the NULL
> setting before the resolver call:
> 
> 	flo = NULL;
> 	if (fle) {
> 		flo = fle->object;
> 		fle->object = NULL;
> 	}
> 	flo = resolver(..., flo, ...);
> 
> This way it's obvious that we've given the reference over to
> the resolver.

Right. I'm fine either way. Is there any preference?