From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 11/13] drm/vmwgfx: don't initialize TTM io memory manager field Date: Mon, 05 Apr 2010 14:21:21 +0200 Message-ID: <4BB9D5C1.40303@shipmail.org> References: <1269535044-17930-1-git-send-email-jglisse@redhat.com> <1269535044-17930-2-git-send-email-jglisse@redhat.com> <1269535044-17930-3-git-send-email-jglisse@redhat.com> <1269535044-17930-4-git-send-email-jglisse@redhat.com> <1269535044-17930-5-git-send-email-jglisse@redhat.com> <1269535044-17930-6-git-send-email-jglisse@redhat.com> <1269535044-17930-7-git-send-email-jglisse@redhat.com> <1269535044-17930-8-git-send-email-jglisse@redhat.com> <1269535044-17930-9-git-send-email-jglisse@redhat.com> <1269535044-17930-10-git-send-email-jglisse@redhat.com> <1269535044-17930-11-git-send-email-jglisse@redhat.com> <1269535044-17930-12-git-send-email-jglisse@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1269535044-17930-12-git-send-email-jglisse@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Jerome Glisse Cc: dri-devel@lists.sf.net List-Id: dri-devel@lists.freedesktop.org Jerome Glisse wrote: > This isn't needed anymore with the new TTM fault callback > > Signed-off-by: Jerome Glisse > Reviewed-by: Thomas Hellstrom > --- > drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c > index 7e28448..a0fb612 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c > @@ -137,9 +137,6 @@ int vmw_invalidate_caches(struct ttm_bo_device *bdev, uint32_t flags) > int vmw_init_mem_type(struct ttm_bo_device *bdev, uint32_t type, > struct ttm_mem_type_manager *man) > { > - struct vmw_private *dev_priv = > - container_of(bdev, struct vmw_private, bdev); > - > switch (type) { > case TTM_PL_SYSTEM: > /* System memory */ > @@ -151,11 +148,8 @@ int vmw_init_mem_type(struct ttm_bo_device *bdev, uint32_t type, > case TTM_PL_VRAM: > /* "On-card" video ram */ > man->gpu_offset = 0; > - man->io_offset = dev_priv->vram_start; > - man->io_size = dev_priv->vram_size; > man->flags = TTM_MEMTYPE_FLAG_FIXED | > TTM_MEMTYPE_FLAG_NEEDS_IOREMAP | TTM_MEMTYPE_FLAG_MAPPABLE; > - man->io_addr = NULL; > man->available_caching = TTM_PL_MASK_CACHING; > man->default_caching = TTM_PL_FLAG_WC; > break; > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev --