From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nyr4s-0001N7-5C
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 14:31:14 -0400
Received: from [140.186.70.92] (port=34568 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nyr4q-0001Mp-VY
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 14:31:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1Nyr4m-000050-NF
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 14:31:12 -0400
Received: from are.twiddle.net ([75.149.56.221]:56746)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1Nyr4m-0008WI-Hx
	for qemu-devel@nongnu.org; Mon, 05 Apr 2010 14:31:08 -0400
Message-ID: <4BBA2C6A.10306@twiddle.net>
Date: Mon, 05 Apr 2010 11:31:06 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/7] Add guest_start_len_valid function.
References: <cover.1270488612.git.rth@twiddle.net>	<8fab352a4e45a8412daed0adb442dc4457279ca0.1270488612.git.rth@twiddle.net>
	<alpine.LNX.2.00.1004052215220.14271@linmac>
In-Reply-To: <alpine.LNX.2.00.1004052215220.14271@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On 04/05/2010 11:15 AM, malc wrote:
> Please do not use double leading underscore.

In contrast to the existing use in:

>>  #define h2g_valid(x) ({ \
>>      unsigned long __guest = (unsigned long)(x) - GUEST_BASE; \

What do you suggest instead?  Trailing underscores?


r~