All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Tso <tytso@mit.edu>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: don't use -s option to repquota
Date: Mon, 05 Apr 2010 14:40:23 -0500	[thread overview]
Message-ID: <4BBA3CA7.8000206@sandeen.net> (raw)
In-Reply-To: <20100405190428.GA3807@infradead.org>

Christoph Hellwig wrote:
> The -s option to repquota used to be a no-op, but actually changes
> output to different units in quota tools 4.0.  Remove it from the
> repquota invocation in test 219.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, Ted was hitting this too.

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

> Index: xfstests-dev/219
> ===================================================================
> --- xfstests-dev.orig/219	2010-04-05 18:55:09.000000000 +0000
> +++ xfstests-dev/219	2010-04-05 18:55:16.000000000 +0000
> @@ -85,7 +85,7 @@ test_accounting()
>  		$here/src/lstat64 $file | head -3 | filter_scratch
>  	done
>  
> -	repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
> +	repquota -$type -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
>  	awk '/^#/ { if (seen[$1]) next; seen[$1]++; } { print; }'
>  }
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-04-05 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05 19:04 [PATCH] xfstests: don't use -s option to repquota Christoph Hellwig
2010-04-05 19:40 ` Eric Sandeen [this message]
2010-04-05 19:45   ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBA3CA7.8000206@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.