From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 2/2] KVM: Trace emulated instructions
Date: Tue, 06 Apr 2010 00:38:00 +0300 [thread overview]
Message-ID: <4BBA5838.6080603@redhat.com> (raw)
In-Reply-To: <20100405184438.GA7141@amt.cnet>
On 04/05/2010 09:44 PM, Marcelo Tosatti wrote:
> On Thu, Mar 25, 2010 at 05:02:56PM +0200, Avi Kivity wrote:
>
>> Log emulated instructions in ftrace, especially if they failed.
>>
> Why not log all emulated instructions? Seems useful to me.
>
>
That was the intent, but it didn't pan out. I tried to avoid
double-logging where an mmio read is dispatched to userspace, and the
instruction is re-executed.
Perhaps we should split it into a decode trace and execution result
trace? Less easy to use but avoids confusion due to duplication.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-04-05 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 15:02 [PATCH 0/2] Trace emulated instrucions Avi Kivity
2010-03-25 15:02 ` [PATCH 1/2] KVM: x86 emulator: Don't overwrite decode cache Avi Kivity
2010-03-25 15:02 ` [PATCH 2/2] KVM: Trace emulated instructions Avi Kivity
2010-04-05 18:44 ` Marcelo Tosatti
2010-04-05 21:38 ` Avi Kivity [this message]
2010-04-06 18:52 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2010-04-11 10:05 [PATCH v2 0/2] Trace emulated instrucions Avi Kivity
2010-04-11 10:05 ` [PATCH 2/2] KVM: Trace emulated instructions Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBA5838.6080603@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.