From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]: block: get rid of the BDRV_O_FILE flag
Date: Tue, 06 Apr 2010 11:21:47 +0200 [thread overview]
Message-ID: <4BBAFD2B.6010105@redhat.com> (raw)
In-Reply-To: <20100405145357.GA25954@lst.de>
Am 05.04.2010 16:53, schrieb Christoph Hellwig:
> BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open.
> It affects two things: first bdrv_open only searches for protocols using
> find_protocol instead of all image formats and host drivers. We can easily
> move that to the caller and pass the found driver to bdrv_open. Second
> it is used to not force a read-write open of a snapshot file. But we never
> use bdrv_file_open to open snapshots and this behaviour doesn't make sense
> to start with.
>
> qemu-io abused the BDRV_O_FILE for it's growable option, switch it to
> using bdrv_file_open to make sure we only open files as growable were
> we can actually support that.
>
> This patch requires Kevin's "[PATCH] Replace calls of old bdrv_open" to
> be applied first.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks like a step in the right direction.
Acked-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2010-04-06 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 14:53 [Qemu-devel] [PATCH]: block: get rid of the BDRV_O_FILE flag Christoph Hellwig
2010-04-06 9:21 ` Kevin Wolf [this message]
2010-04-06 10:35 ` [Qemu-devel] " Juan Quintela
2010-04-06 11:02 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBAFD2B.6010105@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.