From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nz5DP-0005sI-8e for qemu-devel@nongnu.org; Tue, 06 Apr 2010 05:36:59 -0400 Received: from [140.186.70.92] (port=52769 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nz5DN-0005rn-ON for qemu-devel@nongnu.org; Tue, 06 Apr 2010 05:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nz5DL-0000K1-U1 for qemu-devel@nongnu.org; Tue, 06 Apr 2010 05:36:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38985) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz5DL-0000Js-Lw for qemu-devel@nongnu.org; Tue, 06 Apr 2010 05:36:55 -0400 Message-ID: <4BBB008F.1000802@redhat.com> Date: Tue, 06 Apr 2010 11:36:15 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block: split raw_getlength References: <20100405141257.GB24646@lst.de> In-Reply-To: <20100405141257.GB24646@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 05.04.2010 16:12, schrieb Christoph Hellwig: > Split up the raw_getlength into separate generic, solaris and BSD > versions to reduce the ifdef maze a bit. The BSD variant still > is a complete maze, but to clean it up properly we'd need some > people using the BSD variants to figure out what code is used > for what variant. > > Signed-off-by: Christoph Hellwig Seems to leave some duplicate #ifdef CONFIG_BSD around, but that code is a mess anyway and maybe it's the bit of additional ugliness that makes someone of the BSD people clean it up. Anyway, it's definitely an improvement over the current code. Acked-by: Kevin Wolf