From: Dario <djdas@djdas.net>
To: ofono@ofono.org
Subject: Re: [PATCH 2/2] Added SQLite history plugin
Date: Tue, 06 Apr 2010 12:55:39 +0200 [thread overview]
Message-ID: <4BBB132B.1030805@djdas.net> (raw)
In-Reply-To: <97D5E1BB8FC13D4EA3B34BAE8E6898C9C138D0D0@orsmsx508.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
Bastian, Waldo ha scritto:
> The message handling in this patch seems to be vulnerable to SQL injection attacks. See http://en.wikipedia.org/wiki/SQL_injection
>
> Cheers,
> Waldo
Hi Waldo,
I didn't think of a message carrying an SQL injection :)
Honestly I would use prepared statement since start of the job but I
didn't manage how to do them in SQLite but I agree with you they're more
secure and the code is cleaner, so I converted the source to them after
studying their use.
Thank you for your suggestion.
Best Regards,
Dario.
next prev parent reply other threads:[~2010-04-06 10:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 21:51 [PATCH 2/2] Added SQLite history plugin Dario
2010-04-05 2:54 ` Bastian, Waldo
2010-04-06 10:55 ` Dario [this message]
2010-04-06 16:12 ` Bastian, Waldo
-- strict thread matches above, loose matches on Subject: below --
2010-04-06 10:43 Dario
2010-04-06 17:56 ` Denis Kenzior
2010-04-07 8:50 ` Dario
2010-04-07 17:01 ` Denis Kenzior
2010-04-07 17:54 ` Nicola Mfb
2010-04-07 18:05 ` Denis Kenzior
2010-04-07 19:20 ` Nicola Mfb
2010-04-07 19:33 ` Denis Kenzior
2010-04-07 21:26 ` Nicola Mfb
2010-04-07 11:47 ` Nicola Mfb
2010-04-07 17:28 ` Bastian, Waldo
2010-04-07 17:33 ` Denis Kenzior
2010-04-07 17:43 ` Nicola Mfb
2010-04-07 17:55 ` Denis Kenzior
2010-04-07 18:09 ` Nicola Mfb
2010-04-07 18:20 ` Denis Kenzior
2010-04-07 18:03 ` Bastian, Waldo
2010-04-07 18:27 ` Denis Kenzior
2010-04-07 19:28 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBB132B.1030805@djdas.net \
--to=djdas@djdas.net \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.