From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nz9k4-000469-Oe
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 10:27:00 -0400
Received: from [140.186.70.92] (port=56554 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nz9k2-00045l-FC
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 10:26:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Nz9k1-0005vP-1U
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 10:26:58 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:58439)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Nz9k0-0005vE-Mw
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 10:26:57 -0400
Message-ID: <4BBB44A2.8020508@mail.berlios.de>
Date: Tue, 06 Apr 2010 16:26:42 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1270554249-24861-1-git-send-email-weil@mail.berlios.de>
	<1270554249-24861-7-git-send-email-weil@mail.berlios.de>
	<20100406121017.GD16539@redhat.com>
In-Reply-To: <20100406121017.GD16539@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 6/9] eepro100: Support compilation without
	EEPROM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Michael S. Tsirkin schrieb:
> On Tue, Apr 06, 2010 at 01:44:06PM +0200, Stefan Weil wrote:
>   
>> To emulate hardware without an EEPROM,
>> EEPROM_SIZE may be set to 0.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>>  hw/eepro100.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/eepro100.c b/hw/eepro100.c
>> index cedc427..e12ee23 100644
>> --- a/hw/eepro100.c
>> +++ b/hw/eepro100.c
>> @@ -1866,9 +1866,11 @@ static int e100_nic_init(PCIDevice *pci_dev)
>>  
>>      e100_pci_reset(s, e100_device);
>>  
>> +#if EEPROM_SIZE > 0
>>      /* Add 64 * 2 EEPROM. i82557 and i82558 support a 64 word EEPROM,
>>       * i82559 and later support 64 or 256 word EEPROM. */
>>      s->eeprom = eeprom93xx_new(EEPROM_SIZE);
>> +#endif
>>     
>
> I expect long-term EEPROM_SIZE will stop being a compile-time
> constant then?
>
>   
EEPROM_SIZE might be a qdev parameter, so a new eeprom_size
would become part of the device status.

Up to now, there was no need for it.

>>  
>>      /* Handler for memory-mapped I/O */
>>      s->mmio_index =
>> -- 
>> 1.7.0
>>