From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
yaa.bta@gmail.com
Subject: Re: [PATCH upstream-fixes] libata: unlock HPA if device shrunk
Date: Tue, 06 Apr 2010 10:57:09 -0400 [thread overview]
Message-ID: <4BBB4BC5.5070200@garzik.org> (raw)
In-Reply-To: <4BB93DD9.7030909@kernel.org>
On 04/04/2010 09:33 PM, Tejun Heo wrote:
> Some BIOSes don't configure HPA during boot but do so while resuming.
> This causes harddrives to shrink during resume making libata detach
> and reattach them. This can be worked around by unlocking HPA if old
> size equals native size.
>
> Add ATA_DFLAG_UNLOCK_HPA so that HPA unlocking can be controlled
> per-device and update ata_dev_revalidate() such that it sets
> ATA_DFLAG_UNLOCK_HPA and fails with -EIO when the above condition is
> detected.
>
> This patch fixes the following bug.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=15396
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Oleksandr Yermolenko<yaa.bta@gmail.com>
> ---
> drivers/ata/libata-core.c | 74 +++++++++++++++++++++++++++-------------------
> include/linux/libata.h | 1
> 2 files changed, 46 insertions(+), 29 deletions(-)
patch is bigger than I would like for #upstream-fixes... but nothing to
be done about that... applied, thanks
next prev parent reply other threads:[~2010-04-06 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 1:33 [PATCH upstream-fixes] libata: unlock HPA if device shrunk Tejun Heo
2010-04-06 14:57 ` Jeff Garzik [this message]
2010-04-06 21:05 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBB4BC5.5070200@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yaa.bta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.