From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 1/7] tabled: make two dump displays uniform Date: Tue, 06 Apr 2010 12:57:57 -0400 Message-ID: <4BBB6815.7040606@garzik.org> References: <20100401195109.01aa6b6a@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=jD91Tm5yezlaIPZxmAN4MB9xAjMTauvqOY0MVoZNaPs=; b=ZS7i1a/k1h8VXmNcNInJIvuwQO6DgQEnRLQcvTWjli5pMfR8l2qNNLQv8zcRG+x63n mbY3jOfrDC3kALtLVPTRcylj+AjfkfQsRzy2hMupQxvWXrtQ3APssMklmV5A/3RKZiXr 3iQIwhnCSoOnvZOhmrSUoZ0ArpHxxUrx2OpnU= In-Reply-To: <20100401195109.01aa6b6a@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 04/01/2010 09:51 PM, Pete Zaitcev wrote: >> From: Jeff Garzik >> Subject: Re: Tabled issues >> Date: Mon, 29 Mar 2010 15:32:33 -0400 > >> I asserted that the standard stats dump facility must dump >> all available statistics. That does not exclude other methods >> of stat(us) dumping. Your patch added new stats to the HTML-pretty >> version of output, but failed to add the new stats to the standard >> stat dump facility. > > Your wish is my command. > > Signed-off-by: Pete Zaitcev > > --- > server/replica.c | 28 +++++++++++++++++++++++++ > server/server.c | 47 ++++++++++++++++++++++++++++++++++-------- > server/status.c | 22 +------------------ > server/storage.c | 50 +++++++++++++++++++++++++++++++++++++++++---- > server/tabled.h | 3 ++ > 5 files changed, 117 insertions(+), 33 deletions(-) applied, thanks. I will endeavor to make the stats dump more like nfs4d in the future, FWIW.