Re: [PATCH] typdef uintptr_t drm_handle_t; unsigned int is wrong on 64-bit.

[Robert Noland <rnoland@2hip.net>]

Dave Airlie wrote:
> On Sat, Apr 3, 2010 at 11:09 PM, Matthew W. S. Bell
> <matthew@bells23.org.uk> wrote:
>> On Sat, 2010-04-03 at 08:49 +0100, Dave Airlie wrote:
>>> No, its "designed" as is. We can't change it now as its ABI. We make sure
>>> we only use 32-bit handles anyways.
> 
> The thing is "unsigned int" is correct for the handles, they are defined to
> be 32-bit numbers no matter what system they are on, its the use of the
> void * that is actually the problem.
> 
> Its probably not documented well anywhere, though I think the handles are
> 32-bit is written down somewhere.

No, they are not.  They are only 32bit on linux.  The size of handle 
varies with architecture on FreeBSD as it is passed to mmap as an offset 
into memory.  Honestly, I would prefer that they always be 64bits, but 
that would break ABI...  The dual meaning of handle has frustrated me 
more than a few times.

robert.

> Dave.
>> OK, is this documented anywhere, as I'd like to pull some of that into a
>> comment? (It appears, on a casual glance, that this type is not used in
>> the kernel ABI, but only in the libdrm, and associates?, ABI, so could
>> be changed if the SONAME got bumped and anyone cared.)
>>
>> Matthew
>>
>>
>> ------------------------------------------------------------------------------
>> Download Intel&#174; Parallel Studio Eval
>> Try the new software tools for yourself. Speed compiling, find bugs
>> proactively, and fine-tune applications for parallel performance.
>> See why Intel Parallel Studio got high marks during beta.
>> http://p.sf.net/sfu/intel-sw-dev
>> --
>> _______________________________________________
>> Dri-devel mailing list
>> Dri-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/dri-devel
>>
>>
> 
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--