From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzR2P-0006Cy-Av for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:55:05 -0400 Received: from [140.186.70.92] (port=40640 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzR2N-0006Bm-Fm for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzR2L-0005NX-TQ for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:55:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22138) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzR2L-0005NE-J3 for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:55:01 -0400 Message-ID: <4BBC4842.2060208@redhat.com> Date: Wed, 07 Apr 2010 10:54:26 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] block: split raw_getlength References: <20100406171344.GB10881@lst.de> In-Reply-To: <20100406171344.GB10881@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 06.04.2010 19:13, schrieb Christoph Hellwig: > Split up the raw_getlength into separate generic, solaris and BSD > versions to reduce the ifdef maze a bit. The BSD variant still > is a complete maze, but to clean it up properly we'd need some > people using the BSD variants to figure out what code is used > for what variant. > > Signed-off-by: Christoph Hellwig Acked-by: Kevin Wolf This is the same logic that was already correct in v1, only superfluous #ifdefs are removed. Pushed both v2 patches to my block branch. Kevin