From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
Date: Wed, 07 Apr 2010 14:38:02 +0200 [thread overview]
Message-ID: <4BBC7CAA.4000506@redhat.com> (raw)
In-Reply-To: <20100407115806.GC12452@lst.de>
Am 07.04.2010 13:58, schrieb Christoph Hellwig:
> bdrv_open already takes care of this for us.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: qemu/block/raw-posix.c
> ===================================================================
> --- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.573261199 +0200
> +++ qemu/block/raw-posix.c 2010-04-07 13:50:25.180005926 +0200
> @@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
> s->open_flags |= O_RDWR;
> } else {
> s->open_flags |= O_RDONLY;
> - bs->read_only = 1;
> }
>
> /* Use O_DSYNC for write-through caching, no flags for write-back caching,
Acked-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2010-04-07 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 11:58 [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only Christoph Hellwig
2010-04-07 12:38 ` Kevin Wolf [this message]
2010-04-10 0:22 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBC7CAA.4000506@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.