Re: [PATCH 02/10] iw_cxgb4: Add driver, fw, and hw headers.

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

Roland Dreier wrote:
> You have:
>
>  > +struct fw_ri_send_wr {
>  ...
>  > +	__be16 wrid;
>
>  > +struct fw_ri_recv_wr {
>  ...
>  > +	__be16 wrid;
>
> But also:
>
>  > +static inline void init_wr_hdr(union t4_wr *wqe, u16 wrid,
>  > +			       enum fw_wr_opcodes opcode, u8 flags, u8 len16)
>  ...
>  > +	wqe->send.wrid = wrid;
>
> and similar for recv.wrid in qp.c.  sparse correctly warns about this
> endianness clash.
>
> The intention is that the device just treats wrid as opaque I assume so
> I think the correct fix is to go from __be16 to u16 in the structure
> declarations.
>
>  - R.
>   


Yes, it should be a u16 in the wr structs.





--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html