From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzmYv-0004Oz-SW for qemu-devel@nongnu.org; Thu, 08 Apr 2010 03:54:06 -0400 Received: from [140.186.70.92] (port=57733 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzmYp-0004Nr-Ub for qemu-devel@nongnu.org; Thu, 08 Apr 2010 03:54:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzmYl-0001wM-I7 for qemu-devel@nongnu.org; Thu, 08 Apr 2010 03:53:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40956) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzmYj-0001vx-SH for qemu-devel@nongnu.org; Thu, 08 Apr 2010 03:53:54 -0400 Message-ID: <4BBD8B6C.1060207@redhat.com> Date: Thu, 08 Apr 2010 09:53:16 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images References: <20100407115753.GB12452@lst.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Christoph Hellwig , qemu-devel@nongnu.org Am 07.04.2010 17:02, schrieb Stefan Hajnoczi: > On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig wrote: >> Various obscure image format drivers do not allow write access. >> Instead of silently falling back to read-only access reject attempts >> to open these images for write access. > > Does block/curl.c need this too? Yes, looks like it. It even fails to declare itself readonly like those other formats do currently. One more argument for doing it in a central place where no driver would be missed. Kevin