From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Timo_Ter=E4s?= Subject: Re: linux-next: powerpc boot failure Date: Thu, 08 Apr 2010 11:40:13 +0300 Message-ID: <4BBD966D.8020404@iki.fi> References: <20100408165848.38f75f40.sfr@canb.auug.org.au> <4BBD81B3.3030500@iki.fi> <20100408172316.e6ee451d.sfr@canb.auug.org.au> <4BBD85ED.4090209@iki.fi> <20100408174549.2f45ceea.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ew0-f222.google.com ([209.85.219.222]:50159 "EHLO mail-ew0-f222.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410Ab0DHIkS (ORCPT ); Thu, 8 Apr 2010 04:40:18 -0400 In-Reply-To: <20100408174549.2f45ceea.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: David Miller , netdev@vger.kernel.org, linux-next@vger.kernel.org, LKML Stephen Rothwell wrote: > On Thu, 08 Apr 2010 10:29:49 +0300 Timo Ter=E4s w= rote: >> You don't probably have any xfrm policies then. And that code should= not >> really get executed. >> >> Some of the changes touch globally visible structs, and inline funct= ions. >> Was this a clean rebuild? And did you update all kernel modules, als= o in >> the initramfs? >=20 > Yes, the build is started from scratch and the kernel and modules are > updated (this is our automated build and test system). >=20 > I have attached the config in case that is of use. It looks like my new code uses xfrm_pols_put assuming it always does th= e proper thing. But seems like it's doing funny stuff if CONFIG_XFRM_SUB_= POLICY is not set, which is your case. Can you try if this helps? diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 625dd61..cccb049 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -735,19 +735,12 @@ static inline void xfrm_pol_put(struct xfrm_polic= y *policy xfrm_policy_destroy(policy); } =20 -#ifdef CONFIG_XFRM_SUB_POLICY static inline void xfrm_pols_put(struct xfrm_policy **pols, int npols) { int i; for (i =3D npols - 1; i >=3D 0; --i) xfrm_pol_put(pols[i]); } -#else -static inline void xfrm_pols_put(struct xfrm_policy **pols, int npols) -{ - xfrm_pol_put(pols[0]); -} -#endif =20 extern void __xfrm_state_destroy(struct xfrm_state *); =20