From: Richard Henderson <rth@twiddle.net>
To: mattst88@gmail.com
Cc: linux-alpha@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Subject: Re: [PATCH] alpha: simplify and optimize sched_find_first_bit
Date: Thu, 08 Apr 2010 11:52:32 -0700 [thread overview]
Message-ID: <4BBE25F0.8060209@twiddle.net> (raw)
In-Reply-To: <1270751656-5614-1-git-send-email-mattst88@gmail.com>
On 04/08/2010 11:34 AM, mattst88@gmail.com wrote:
> - return __ffs(b0) + ofs;
> + unsigned long output;
> + asm(
> + "cmoveq %0,64,%1 # ofs = (b[0] ? ofs : 64);\n"
> + "cmoveq %0,%2,%0 # temp = (b[0] ? b[0] : b[1]);\n"
> + "cttz %0,%0 # output = cttz(temp);\n "
> + : "=r" (output), "=r" (ofs)
> + : "r" (b[1]), "0" (b[0]), "1" (0)
> + );
> + return output + ofs;
NACK.
You need to move that cttz out of the asm as well, to continue
to support pre-ev67. Ack if you adjust to use __ffs.
r~
next prev parent reply other threads:[~2010-04-08 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 18:34 [PATCH] alpha: simplify and optimize sched_find_first_bit mattst88
2010-04-08 18:52 ` Richard Henderson [this message]
[not found] ` <4BBE2B5C.6020802@twiddle.net>
2010-04-29 2:08 ` Matt Turner
-- strict thread matches above, loose matches on Subject: below --
2010-04-29 3:37 Matt Turner
2010-04-29 3:56 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE25F0.8060209@twiddle.net \
--to=rth@twiddle.net \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.