All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>,
	James.Bottomley@suse.de, linux scsi <linux-scsi@vger.kernel.org>
Subject: Re: PATCH] BNX2I : Bug fixes related to MTU change issue when there are active iscsi sessions
Date: Thu, 08 Apr 2010 17:31:06 -0500	[thread overview]
Message-ID: <4BBE592A.2070202@cs.wisc.edu> (raw)
In-Reply-To: <1270761372.28522.109699.camel@anilgv-desktop>

On 04/08/2010 04:16 PM, Anil Veerabhadrappa wrote:
> +	/* Wait for all endpoints to be torn down, Chip will be reset once
> +	 *  control returns to network driver. So it is required to cleanup and
> +	 * release all connection resources before returning from this routine.
> +	 */
> +	wait_event_interruptible_timeout(hba->eh_wait,
> +					 (hba->ofld_conns_active == 0),
> +					 hba->hba_shutdown_tmo);


Hey, I just noticed this (sorry I should have seen this earlier), but 
there is no wake_up(hba->eh_wait). Do you want one in bnx2i_free_ep when 
ofld_conns_active goes to 0?

  reply	other threads:[~2010-04-08 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 21:16 PATCH] BNX2I : Bug fixes related to MTU change issue when there are active iscsi sessions Anil Veerabhadrappa
2010-04-08 22:31 ` Mike Christie [this message]
     [not found]   ` <4BBE592A.2070202-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2010-04-08 22:45     ` Anil Veerabhadrappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBE592A.2070202@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@suse.de \
    --cc=anilgv@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.