From: Harshavardhana <harsha@gluster.com>
To: David Brown <btrfs@davidb.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots
Date: Thu, 08 Apr 2010 15:35:40 -0700 [thread overview]
Message-ID: <4BBE5A3C.5060804@gluster.com> (raw)
In-Reply-To: <20100408220717.GA15666@arch.davidb.org>
On 04/08/2010 03:07 PM, David Brown wrote:
> On Thu, Apr 08, 2010 at 01:35:31PM -0700, Harshavardhana wrote:
>
>
>> if (inode->i_size > BTRFS_EMPTY_DIR_SIZE ||
>> inode->i_ino == BTRFS_FIRST_FREE_OBJECTID)
>> - return -ENOTEMPTY;
>> + return -EPERM;
>
> Don't you want to still return ENOTEMPTY for the size check, and only
> the EPERM on the root of subvolume?
>
> David
Yep my bad. i_size check has to be ENOTEMPTY
Thanks
--
Harshavardhana
http://www.gluster.com
prev parent reply other threads:[~2010-04-08 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 20:35 [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots Harshavardhana
2010-04-08 22:07 ` David Brown
2010-04-08 22:35 ` Harshavardhana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE5A3C.5060804@gluster.com \
--to=harsha@gluster.com \
--cc=btrfs@davidb.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.